Skip to content

(#187) Fix installing multiple packages with force #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Windos wants to merge 1 commit into
base: master
Choose a base branch
from
Open

(#187) Fix installing multiple packages with force #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion chocolatey/plugins/modules/win_chocolatey.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,9 @@ if ($state -in @("downgrade", "latest", "upgrade", "present", "reinstalled")) {
$missingPackages = [System.Collections.Generic.List[string]]@()

if ($state -eq "present" -and $force) {
$missingPackages.Add($name)
foreach ($package in $name) {
$missingPackages.Add($package)
}
}
else {
foreach ($package in $packageInfo.GetEnumerator()) {
Expand Down
14 changes: 14 additions & 0 deletions chocolatey/tests/integration/targets/win_chocolatey/tasks/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,3 +751,17 @@
that:
- ignore_pinned_upgrade is changed
- ignore_pinned_upgrade is not failed

- name: force install multiple packages
win_chocolatey:
name:
- '{{ test_choco_package1 }}'
- '{{ test_choco_package2 }}'
state: present
register: force_install_multiple

- name: assert force install multiple packages
assert:
that:
- force_install_multiple is changed
- force_install_multiple is not failed