(#187) Fix installing multiple packages with force#188
Open
Windos wants to merge 1 commit intochocolatey:masterfrom
Open
(#187) Fix installing multiple packages with force#188Windos wants to merge 1 commit intochocolatey:masterfrom
Windos wants to merge 1 commit intochocolatey:masterfrom
Conversation
Currently, when using the force flag on the win_chocolatey command the list of packages is being added to the collection of missing packages as a single string. This results in the packages being passed to choco.exe bounded by quote character (e.g. `"package1 package2"`) and so this is being interpreted as a single (incorrect) package name. This change iterates over the list of packages and adds them individually. Additionally, tests have been added to cover this failure case.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This PR ensures that lists of packages are still treated as lists when provided alongside the
Forceflag onwin_chocolatey.Additionally, tests have been added to cover the failure case that this change fixes.
Motivation and Context
Currently, when using the force flag on the win_chocolatey command the list of packages is being added to the collection of missing packages as a single string. This results in the packages being passed to choco.exe bounded by quote character (e.g.
"package1 package2") and so this is being interpreted as a single (incorrect) package name.Testing
Operating Systems Testing
N/A
Change Types Made
Change Checklist
Related Issue
Fixes #187