Skip to content

e2e-tests: Forward signals to robot to support CI job cancellation #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adombeck wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

e2e-tests: Forward signals to robot to support CI job cancellation #1605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion e2e-tests/run-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,13 @@ env \
"${ROBOT_ARGS[@]}" \
"$@" \
"${TESTS_TO_RUN[@]}" \
|| test_result=$?
&
robot_pid=$!

# Forward SIGTERM/SIGINT to robot so that CI job cancellation reaches it.
# Without this, bash exits on SIGTERM but leaves robot running as an orphan.
trap 'kill $robot_pid 2>/dev/null' SIGTERM SIGINT

wait $robot_pid || test_result=$?

exit "${test_result:-0}"
Loading