e2e-tests: Forward signals to robot to support CI job cancellation#1605
Draft
adombeck wants to merge 1 commit into
Draft
e2e-tests: Forward signals to robot to support CI job cancellation#1605adombeck wants to merge 1 commit into
adombeck wants to merge 1 commit into
Conversation
GitHub Actions sends SIGTERM only to the bash process running the step, not to the whole process group. Without a signal trap, bash would exit immediately on SIGTERM but leave robot running as an orphan, preventing the CI job from being cancelled. Running robot in the background and forwarding SIGTERM/SIGINT to it allows Robot Framework's own signal handler to perform a graceful shutdown when the CI job is cancelled. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
adombeck
added
the
e2e-tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1605 +/- ##
==========================================
- Coverage 87.75% 87.54% -0.21%
==========================================
Files 98 98
Lines 6745 6745
Branches 111 111
==========================================
- Hits 5919 5905 -14
- Misses 770 784 +14
Partials 56 56 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions sends SIGTERM only to the bash process running the step, not to the whole process group. Without a signal trap, bash would exit immediately on SIGTERM but leave robot running as an orphan, preventing the CI job from being cancelled.
Running robot in the background and forwarding SIGTERM/SIGINT to it allows Robot Framework's own signal handler to perform a graceful shutdown when the CI job is cancelled.