Repository navigation
Vulkan: re-record camera-dependent scenes instead of replaying - #66
Merged
Merged
Conversation
The retained-IR replay reuses the cached main draw list on a camera-only frame (matched graph fingerprint). That is only sound when every recorded command is camera-independent. A node that bakes the camera pose into its retained output -- FreeCAD's screen-constant-size SoShapeScale (origin planes/axes) and SoAutoZoomTranslation -- breaks that assumption: on a zoom the replayed list keeps the previous camera's derived scale until some unrelated change (e.g. a hover highlight) forces a re-record. Add SoIRRenderAction::setCameraDependent()/isCameraDependent(): a node sets it from its doAction() during an IR traversal. The manager remembers the flag from the last record and refuses the camera-only replay while the camera version differs from the one the list was recorded at, so such scenes re-record on camera moves. Scenes without such nodes keep replaying.
brianmk
force-pushed
the
perf/vulkan-hotpath
branch
from
September 28, 2026 02:34
991d63a to
16d89c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #65. The retained-IR replay reuses the cached main draw list on a camera-only frame (matched graph fingerprint), which is only sound when every recorded command is camera-independent.
A node that bakes the camera pose into its retained output -- FreeCAD's screen-constant-size
SoShapeScale(origin planes/axes) andSoAutoZoomTranslation-- breaks that assumption: on a zoom the replayed list keeps the previous camera's derived scale until some unrelated change (e.g. a hover highlight) forces a re-record, so the origin planes do not rescale while zooming.SoIRRenderAction::setCameraDependent()/isCameraDependent(): a node sets it from itsdoAction()during an IR traversal.apply=0.00on zoom; datum/origin scene re-records).