Repository navigation
Gui/Vulkan: rescale camera-dependent datum scenes on zoom - #117
Merged
Merged
Conversation
The Vulkan retained-IR replay reuses the cached main draw list on a camera-only frame, which is only sound when every recorded command is camera-independent. The screen-constant-size origin planes/axes (SoShapeScale) and SoAutoZoomTranslation bake a view-volume-derived scale into the retained list, so on a zoom the replay kept the previous camera's scale until an unrelated change (e.g. a hover) forced a re-record. Mark these nodes camera-dependent on the IR action (SoIRRenderAction::setCameraDependent) and bump coin to the manager change that refuses the camera-only replay for such scenes. Verified: a box-only scene still replays (apply=0.00) on zoom; a datum/origin scene re-records.
… pass vkCmdResetQueryPool may not be recorded inside a render pass, so reset the pool before vkCmdBeginRenderPass; the backend scopes then emit the [RTDBG] gpuTiming renderPass=<ms> lines (otherwise inert).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the sketch/Body origin planes not rescaling while zooming under Vulkan (they only updated when a hover forced a re-record).
Cause. The retained-IR replay reuses the cached main draw list on a camera-only frame. That is only sound when every recorded command is camera-independent; the screen-constant-size origin planes/axes (
SoShapeScale) andSoAutoZoomTranslationbake a view-volume-derived scale into the retained list, so a zoom replayed the previous camera's scale.Fix.
SoIRRenderAction::setCameraDependent) from theirdoAction().vkCmdBeginRenderPassso the[RTDBG] gpuTiming renderPass=lines actually emit (follow-up to coin#65).Verified (build-perf): box-only scene still replays on zoom (
apply=0.00×7); datum/origin scene now re-records on zoom (apply>0), so the planes rescale;gpuTiming renderPass=lines appear.