Repository navigation
Help text on the row names - #111
Merged
benjamindehli merged 1 commit intoNov 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The names down the left of the mixer, like strike, swell and level, don't explain themselves. Someone new to the instrument had to open the manual to find out what STRIKE does, or what "level" under KEY OFF means. The controls in the bars along the top already had help text, but the row names had none.
Holding the pointer over a row name now shows a short tooltip saying what the row does. Every name in the gutter has one, the section headings and the cents and dB readouts included. The headings also say that clicking them folds the section. The two shape, rate and depth rows say whether they belong to the vibrato or the tremolo, and the mute and solo line names the right key for Option-click on each platform. The texts follow the manual's own description of each row.
The names are painted as text with no component of their own, so the gutter works out which row is under the pointer from the same layout it draws the names with. A folded row has no tooltip, and the rows below it keep theirs as they move up. Only LEVEL's caption has one, not the fader band under it. The texts sit in
rowHelpinTheme.cpp, besiderowLabel.What changes for users
How it was checked
A new runtime test lays out the gutter as it is drawn and checks that:
I let the whole fader band show LEVEL's help to see that check fail, and it did. The runtime suite passes with 1517 checks and no failures. clang-format, prettier,
build_site.py --checkand the lambda scan pass too.Closes #102