Skip to content

WS-2471-Fix whitespace above PV curation heading #13895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nabeel1276 wants to merge 3 commits into
base: latest
Choose a base branch
from
+6 −2
Open

WS-2471-Fix whitespace above PV curation heading #13895

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4553bd
Fixed margin between horizontal line and PV curation heading
Nabeel1276 Apr 9, 2026
c6001c2
Merge branch 'latest' into WS-2471-fix-whitespace-above-pv-curation-h…
Nabeel1276 Apr 9, 2026
5b13985
Merge branch 'latest' into WS-2471-fix-whitespace-above-pv-curation-h…
Nabeel1276 Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/app/components/ContinueReadingButton/index.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default {
display: 'block',
width: `calc(100% - ${spacings.QUADRUPLE}rem)`,
padding: `${spacings.DOUBLE}rem 0`,
margin: `0 ${spacings.DOUBLE}rem -${spacings.FULL}rem ${spacings.DOUBLE}rem`,
margin: `0 ${spacings.DOUBLE}rem ${pixelsToRem(36)}rem ${spacings.DOUBLE}rem`,
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description still contains the template placeholders (summary/code changes/testing) without concrete details. Please add a brief user-facing summary and explicit testing steps (e.g. which page to load and expected whitespace change) so reviewers can verify the visual adjustment reliably.

Copilot uses AI. Check for mistakes.
backgroundColor: palette.GREY_2,
color: palette.GREY_10,
textAlign: 'start',
Expand All @@ -33,10 +33,14 @@ export default {
},

[mq.GROUP_1_MAX_WIDTH]: {
margin: `0 ${spacings.FULL}rem -${spacings.HALF}rem ${spacings.FULL}rem`,
margin: `0 ${spacings.FULL}rem ${pixelsToRem(36)}rem ${spacings.FULL}rem`,
width: `calc(100% - ${spacings.DOUBLE}rem)`,
},

[mq.GROUP_3_MIN_WIDTH]: {
margin: `0 ${spacings.DOUBLE}rem ${pixelsToRem(20)}rem ${spacings.DOUBLE}rem`,
},
Comment on lines 14 to +42
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new bottom margins use hard-coded pixel values (36px/20px via pixelsToRem) that don’t map to the theme spacing scale (which is based on 8px steps). To keep spacing consistent and self-documenting, consider using existing spacings.* tokens where possible, or introduce a named constant in this file explaining why these non-standard values are required (e.g. alignment with PV curation heading).

Copilot uses AI. Check for mistakes.

'&:hover, &:focus': {
textDecoration: 'underline',
},
Expand Down
Loading