Skip to content

WS-2471-Fix whitespace above PV curation heading #13895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nabeel1276 wants to merge 7 commits into
base: latest
Choose a base branch
from
+6 −2
Open

WS-2471-Fix whitespace above PV curation heading #13895

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f4553bd
Fixed margin between horizontal line and PV curation heading
Nabeel1276 Apr 9, 2026
c6001c2
Merge branch 'latest' into WS-2471-fix-whitespace-above-pv-curation-h…
Nabeel1276 Apr 9, 2026
5b13985
Merge branch 'latest' into WS-2471-fix-whitespace-above-pv-curation-h…
Nabeel1276 Apr 9, 2026
94ec580
Merge branch 'latest' into WS-2471-fix-whitespace-above-pv-curation-h…
Nabeel1276 Apr 13, 2026
05dc6e2
Merge branch 'latest' into WS-2471-fix-whitespace-above-pv-curation-h…
Nabeel1276 Apr 13, 2026
279e98e
Merge branch 'latest' into WS-2471-fix-whitespace-above-pv-curation-h…
Nabeel1276 Apr 13, 2026
048bfef
Updated margin sizes as they were too big
Nabeel1276 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/app/components/ContinueReadingButton/index.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default {
display: 'block',
width: `calc(100% - ${spacings.QUADRUPLE}rem)`,
padding: `${spacings.DOUBLE}rem 0`,
margin: `0 ${spacings.DOUBLE}rem -${spacings.FULL}rem ${spacings.DOUBLE}rem`,
margin: `0 ${spacings.DOUBLE}rem ${pixelsToRem(12)}rem ${spacings.DOUBLE}rem`,
backgroundColor: palette.GREY_2,
color: palette.GREY_10,
textAlign: 'start',
Expand All @@ -33,10 +33,14 @@ export default {
},

[mq.GROUP_1_MAX_WIDTH]: {
margin: `0 ${spacings.FULL}rem -${spacings.HALF}rem ${spacings.FULL}rem`,
margin: `0 ${spacings.FULL}rem ${pixelsToRem(12)}rem ${spacings.FULL}rem`,
width: `calc(100% - ${spacings.DOUBLE}rem)`,
},

[mq.GROUP_3_MIN_WIDTH]: {
margin: `0 ${spacings.DOUBLE}rem -${spacings.HALF}rem ${spacings.DOUBLE}rem`,
Copy link
Copy Markdown
Contributor

@hotinglok hotinglok Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
margin: `0 ${spacings.DOUBLE}rem -${spacings.HALF}rem ${spacings.DOUBLE}rem`,
margin: `0 ${spacings.DOUBLE}rem`,

Can you ask UX if this can be changed to remove the negative margin? At the moment, this makes the total spacing between the line and the top of the heading 36px with the negative margin being -4px. Removing this doesn't change much visually (to me anyways) but makes the styling a bit simpler. I feel like the negative margin probably caused a bit of confusion early on.

Copy link
Copy Markdown
Contributor Author

@Nabeel1276 Nabeel1276 Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But with the removal of the negative margin, would the total spacing still be 36px?

},

'&:hover, &:focus': {
textDecoration: 'underline',
},
Expand Down
Loading