-
Notifications
You must be signed in to change notification settings - Fork 272
WS-2288 Implement Dazzler Edge Plugin & Temporal Polyfill in Simorgh #13783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: latest
Are you sure you want to change the base?
Changes from 7 commits
3c0cdf3
23d5e4b
ecc7ee2
8520811
a70e8b5
961e9b4
c17a4ff
52cdc17
4cc16fe
5e51435
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| import onClient from '#app/lib/utilities/onClient'; | ||
| import isLive from '#app/lib/utilities/isLive'; | ||
| import filterForBlockType from '#app/lib/utilities/blockHandlers'; | ||
| import { LIVE_TV_PAGE } from '#app/routes/utils/pageTypes'; | ||
| import { BuildConfigProps, PlayerConfig } from '../types'; | ||
| import configForMediaBlockType from '../configs'; | ||
|
|
||
|
|
@@ -22,6 +23,8 @@ const isTestRequested = () => { | |
| return false; | ||
| }; | ||
|
|
||
| const dazzlerStreamLangs = ['hi']; | ||
|
|
||
| const buildSettings = ({ | ||
| id, | ||
| blocks, | ||
|
|
@@ -56,7 +59,14 @@ const buildSettings = ({ | |
| }, | ||
| ...(!embedded && { superResponsive: true }), | ||
| ...(counterName && { counterName }), | ||
| ...(isTestRequested() && { mediator: { host: 'open.test.bbc.co.uk' } }), | ||
| ...(isTestRequested() && { | ||
| mediator: { | ||
| host: | ||
| dazzlerStreamLangs.includes(lang) && pageType === LIVE_TV_PAGE | ||
| ? 'open.live.bbc.co.uk' | ||
| : 'open.test.bbc.co.uk', | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There isn't a PIPS stream on test, so we need to use the live endpoint in order to see it working when not on live. Harvey has looked into whether we can curate a test PIPS stream to use, but it doesn't seem possible https://bbc-tpg.slack.com/archives/C03RMKNL7GC/p1772618041978389 This is a workaround so that we can see the stream on test and preview.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this something we're removing once its been tested on Preview?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could do? I was thinking it might be helpful to leave in place for ease of testing in future, but maybe we could leave a comment somewhere nearby instead to indicate that it needs to be edited when locally developing. Is there a downside to leaving it in?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It just means that Hindi Live TV pages will always use the Live mediator.host and the more languages we add will do the same? I'm not across the Dazzler stuff, so maybe its needed, but typically its best to keep environments isolated, rather than mixing Test/Live endpoints as it can lead to unexpected behaviour. |
||
| }, | ||
| }), | ||
| statsObject: { | ||
| destination: statsDestination, | ||
| producer, | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.