-
Notifications
You must be signed in to change notification settings - Fork 272
WS-2288 Implement Dazzler Edge Plugin & Temporal Polyfill in Simorgh #13783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HarveyPeachey
wants to merge
10
commits into
latest
Choose a base branch
from
WS-2031-simorgh-dazzler-stream
base: latest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3c0cdf3
bbc hindi tv dazzler stream
HarveyPeachey 23d5e4b
remove hardcoding of values in liveMedia config
emilysaffron ecc7ee2
Merge branch 'latest' into WS-2031-simorgh-dazzler-stream
emilysaffron 8520811
fix merge
emilysaffron a70e8b5
allow list hindi streams to use live endpoint for pips streams
emilysaffron 961e9b4
limit to livetv
emilysaffron c17a4ff
Merge branch 'latest' into WS-2031-simorgh-dazzler-stream
emilysaffron 52cdc17
Merge branch 'latest' into WS-2031-simorgh-dazzler-stream
emilysaffron 4cc16fe
use getEnvConfig
emilysaffron 5e51435
Merge branch 'WS-2031-simorgh-dazzler-stream' of github.com:bbc/simor…
emilysaffron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't a PIPS stream on test, so we need to use the live endpoint in order to see it working when not on live. Harvey has looked into whether we can curate a test PIPS stream to use, but it doesn't seem possible https://bbc-tpg.slack.com/archives/C03RMKNL7GC/p1772618041978389
This is a workaround so that we can see the stream on test and preview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something we're removing once its been tested on Preview?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could do? I was thinking it might be helpful to leave in place for ease of testing in future, but maybe we could leave a comment somewhere nearby instead to indicate that it needs to be edited when locally developing.
Is there a downside to leaving it in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It just means that Hindi Live TV pages will always use the Live mediator.host and the more languages we add will do the same?
I'm not across the Dazzler stuff, so maybe its needed, but typically its best to keep environments isolated, rather than mixing Test/Live endpoints as it can lead to unexpected behaviour.