Create external/_main under the execroot#29627
Draft
fmeum wants to merge 1 commit into
Draft
Conversation
fmeum
force-pushed
the
create-_main
branch
2 times, most recently
from
b75072d to
cdfee65
Compare
github-actions
Bot
added
team-Core
fmeum
commented
May 23, 2026
fmeum
commented
May 23, 2026
fmeum
force-pushed
the
create-_main
branch
4 times, most recently
from
b324131 to
ae47399
Compare
fmeum
force-pushed
the
create-_main
branch
3 times, most recently
from
4f08ef3 to
2fecab1
Compare
This is needed to correctly resolve rewritten cross-repo symlinks that arise as action inputs on Windows, which resolves symlinks logically (unlike Unix). Skipped on filesystems that can only emulate symlinks (Windows without Developer Mode / symlink privilege): a junction would create a cycle through the `bazel-<workspace>` convenience symlink for any tool that walks the workspace, and is also unnecessary since `replantSymlinks` falls back to non-relative targets under the same condition. Fixes bazelbuild#29515
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation
This is needed to correctly resolve rewritten cross-repo symlinks that arise as action inputs on Windows, which resolves symlinks logically (unlike Unix).
Fixes #29515
Build API Changes
No
Checklist
Release Notes
RELNOTES: None