[DO NOT MERGE] Verify #29627 test catches bug without the fix#29640
Closed
fmeum wants to merge 2 commits into
Closed
[DO NOT MERGE] Verify #29627 test catches bug without the fix#29640fmeum wants to merge 2 commits into
fmeum wants to merge 2 commits into
Conversation
This is needed to correctly resolve rewritten cross-repo symlinks that arise as action inputs on Windows, which resolves symlinks logically (unlike Unix). Skipped on filesystems that can only emulate symlinks (Windows without Developer Mode / symlink privilege): a junction would create a cycle through the `bazel-<workspace>` convenience symlink for any tool that walks the workspace, and is also unnecessary since `replantSymlinks` falls back to non-relative targets under the same condition. Fixes bazelbuild#29515
fmeum
force-pushed
the
verify-test-without-fix
branch
3 times, most recently
from
cf50aff to
208a2f8
Compare
fmeum
force-pushed
the
verify-test-without-fix
branch
from
208a2f8 to
5c9e19f
Compare
Collaborator
Author
|
Verification confirmed: this branch with the Java fix reverted but the new test kept makes the test fail on Linux with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verification-only PR for #29627. Reverts the SymlinkForest fix but keeps the new
testRepoWithWorkspaceSymlinkSurvivesWorkspaceMove*tests, to confirm the test fails on Windows without the fix (matching the original reproducer behavior).Will be closed once verification is done.