Skip to content

Issue #11: Some fixes for generated URLs that were giving me errors. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laryn wants to merge 1 commit into
base: 1.x-2.x
Choose a base branch
from
Open

Issue #11: Some fixes for generated URLs that were giving me errors. #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion forum.admin.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ function forum_overview($form, &$form_state) {
$term = $form[$key]['#term'];
$form[$key]['view']['#href'] = 'forum/' . $term['tid'];
$form[$key]['operations']['#links']['edit']['title'] = t('edit forum');
$form[$key]['operations']['#links']['edit']['href'] = 'admin/structure/forum/edit/forum/' . $term['tid'];
$form[$key]['operations']['#links']['edit']['href'] = 'admin/structure/forum/' . $term['tid'];

@herbdool herbdool Mar 20, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not clear on why you want to change it from the edit link to something else. This link shows up on the admin side for editing forum categories.

}
}

Expand Down
2 changes: 1 addition & 1 deletion forum.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ function forum_node_view($node, $view_mode) {
if ($parents = taxonomy_term_load_parents_all($node->forum_tid)) {
$parents = array_reverse($parents);
foreach ($parents as $parent) {
$breadcrumb[] = l($parent->name, 'forum/' . $parent->name);
$breadcrumb[] = l($parent->name, 'forum/'.str_replace(' ', '-',(strtolower($parent->name))));

@herbdool herbdool Mar 20, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of the box this module seems to use the term id: $breadcrumb[] = l($parent->name, 'forum/' . $parent->tid); and this PR seems to be conflicting with that. So might need to have a condition if the path module is enabled.

}
}
backdrop_set_breadcrumb($breadcrumb);
Expand Down