Issue #11: Some fixes for generated URLs that were giving me errors. - #12
Open
laryn wants to merge 1 commit into
Open
Issue #11: Some fixes for generated URLs that were giving me errors.#12laryn wants to merge 1 commit into
laryn wants to merge 1 commit into
Conversation
herbdool
requested changes
Mar 20, 2019
| $form[$key]['view']['#href'] = 'forum/' . $term['tid']; | ||
| $form[$key]['operations']['#links']['edit']['title'] = t('edit forum'); | ||
| $form[$key]['operations']['#links']['edit']['href'] = 'admin/structure/forum/edit/forum/' . $term['tid']; | ||
| $form[$key]['operations']['#links']['edit']['href'] = 'admin/structure/forum/' . $term['tid']; |
Contributor
There was a problem hiding this comment.
I'm not clear on why you want to change it from the edit link to something else. This link shows up on the admin side for editing forum categories.
| $parents = array_reverse($parents); | ||
| foreach ($parents as $parent) { | ||
| $breadcrumb[] = l($parent->name, 'forum/' . $parent->name); | ||
| $breadcrumb[] = l($parent->name, 'forum/'.str_replace(' ', '-',(strtolower($parent->name)))); |
Contributor
There was a problem hiding this comment.
Out of the box this module seems to use the term id: $breadcrumb[] = l($parent->name, 'forum/' . $parent->tid); and this PR seems to be conflicting with that. So might need to have a condition if the path module is enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think there are still some kinks in terms of the URLs that are being generated -- some examples here. (There may be more).