Add s3 v4 auth header for streaming from non-public s3 buckets#98
Merged
Add s3 v4 auth header for streaming from non-public s3 buckets#98
Conversation
cjcolvar
changed the title
cjcolvar
force-pushed
the
aws_min_s3_auth
branch
from
bb6e1c4 to
ea7b550
Compare
Member
Author
|
TODO: Add documentation about how to use the environment variables to setup s3 authorization and streaming. |
cjcolvar
force-pushed
the
aws_min_s3_auth
branch
from
ea7b550 to
3d5723d
Compare
…precated anyways)
cjcolvar
force-pushed
the
aws_min_s3_auth
branch
from
3d5723d to
1e01f8e
Compare
Member
Author
|
I added documentation for the environment variables. This is ready for review now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work makes use of https://github.com/nginx/nginx-s3-gateway/ in the minimal way to solve our use case. Another resource used in this work was
https://docs.aws.amazon.com/AmazonS3/latest/API/RESTAuthentication.htmlhttps://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-auth-using-authorization-header.htmlThis has been built and pushed to docker hub with the tag
noble-s3authnoble-s3authv4.The new docker image built from this branch has been deployed to avalon-dev (minio) and btaa-prod (versity gateway) and is working in both environments.
After this is merged to
aws_minI think it would be good to bring it back intomainand then build and push new docker images from there.