[ty] update semantic tokens tests expectations#24764
Merged
MichaReiser merged 1 commit intoastral-sh:mainfrom Apr 21, 2026
Merged
[ty] update semantic tokens tests expectations#24764MichaReiser merged 1 commit intoastral-sh:mainfrom
MichaReiser merged 1 commit intoastral-sh:mainfrom
Conversation
denyszhak
requested review from
AlexWaygood,
BurntSushi,
Gankra,
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
denyszhak
commented
Apr 21, 2026
| "t" @ 651..652: Variable [definition] | ||
| "MyClass" @ 655..662: Class | ||
| "prop" @ 663..667: Property [readonly] | ||
| "MyClass" @ 65..72: Class [definition] |
Contributor
Author
There was a problem hiding this comment.
@MichaReiser sorry it's shifted the only different is in u = MyClass.__name__ but it still resolves into a variable and I think for it to be a property it requires implementation change
denyszhak
commented
Apr 21, 2026
| fn decorator_classification() { | ||
| let test = SemanticTokenTest::new( | ||
| r#" | ||
| class App: |
Contributor
Author
There was a problem hiding this comment.
@MichaReiser
To make sure this test covers complex decorator path as per your comment here #24718 (comment)
denyszhak
changed the title
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes astral-sh/ty#3090
Summary
Adjust tests expectations as a follow up to #24718