Always include panic payload in panic diagnostic message#24873
Merged
MichaReiser merged 1 commit intomainfrom Apr 27, 2026
Merged
Always include panic payload in panic diagnostic message#24873MichaReiser merged 1 commit intomainfrom
MichaReiser merged 1 commit intomainfrom
Conversation
MichaReiser
changed the title
MichaReiser
requested review from
AlexWaygood,
carljm,
dcreager,
ibraheemdev and
sharkdp
as code owners
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our panic handler omits the panic payload if it is neither a
strorStringtoday. This can be confusing because it appears the user's report misses the crucial message, when in fact it's simply that the panic body is a non-string value (see astral-sh/ty#3339).This PR changes the diagnostic rendering to always include the panic payload, even if it's just a
Box<dyn Any>. While that isn't terribly useful on its own, it at least indicates that the panic body isn't a string value. This PR also adds special handling forsalsa::Cancelled, as these are the most likely non-stringish panic bodies in ty.This aligns the behavior with what we use in mdtests.