[ty] Support `**` unpacking of `TypedDict` in dict-literal assignments by charliermarsh · Pull Request #24703 · astral-sh/ruff

charliermarsh · 2026-04-17T23:20:59Z

Summary

We already support ** unpacking of TypedDict in named TypedDict constructors; this PR extends it to literals annotated as TypedDict, as in:

from typing import TypedDict

class MyTypedDict1(TypedDict):
    aaa: int
    bbb: int

class MyTypedDict2(TypedDict):
    aaa: int
    bbb: int
    ccc: int

d1: MyTypedDict1 = {
    "aaa": 1,
    "bbb": 2,
}

d2: MyTypedDict2 = {
    **d1,
    "ccc": 3,
}

Closes astral-sh/ty#1493

astral-sh-bot · 2026-04-17T23:22:45Z

Typing conformance results

No changes detected ✅

Current numbers

The percentage of diagnostics emitted that were expected errors held steady at 87.94%. The percentage of expected errors that received a diagnostic held steady at 83.36%. The number of fully passing files held steady at 79/133.

astral-sh-bot · 2026-04-17T23:24:00Z

Memory usage report

Memory usage unchanged ✅

astral-sh-bot · 2026-04-17T23:25:58Z

`ecosystem-analyzer` results

Lint rule	Added	Removed	Changed
`missing-typed-dict-key`	0	37	0
`invalid-return-type`	0	5	0
Total	0	42	0

Raw diff (42 changes)

core (https://github.com/home-assistant/core)
- homeassistant/components/energy/data.py:786:20 error[missing-typed-dict-key] Missing required key 'stat_energy_from' in TypedDict `BatterySourceType` constructor
- homeassistant/components/energy/data.py:786:20 error[missing-typed-dict-key] Missing required key 'stat_energy_to' in TypedDict `BatterySourceType` constructor
- homeassistant/components/energy/data.py:786:20 error[missing-typed-dict-key] Missing required key 'type' in TypedDict `BatterySourceType` constructor
- homeassistant/components/energy/data.py:786:20 error[invalid-return-type] Return type does not match returned value: expected `BatterySourceType`, found `dict[str, Unknown | str]`
- homeassistant/components/energy/data.py:789:16 error[missing-typed-dict-key] Missing required key 'stat_energy_from' in TypedDict `BatterySourceType` constructor
- homeassistant/components/energy/data.py:789:16 error[missing-typed-dict-key] Missing required key 'stat_energy_to' in TypedDict `BatterySourceType` constructor
- homeassistant/components/energy/data.py:789:16 error[missing-typed-dict-key] Missing required key 'type' in TypedDict `BatterySourceType` constructor
- homeassistant/components/energy/data.py:789:16 error[invalid-return-type] Return type does not match returned value: expected `BatterySourceType`, found `dict[str, Unknown | str]`
- homeassistant/components/energy/data.py:804:20 error[missing-typed-dict-key] Missing required key 'cost_adjustment_day' in TypedDict `GridSourceType` constructor
- homeassistant/components/energy/data.py:804:20 error[missing-typed-dict-key] Missing required key 'entity_energy_price' in TypedDict `GridSourceType` constructor
- homeassistant/components/energy/data.py:804:20 error[missing-typed-dict-key] Missing required key 'entity_energy_price_export' in TypedDict `GridSourceType` constructor
- homeassistant/components/energy/data.py:804:20 error[missing-typed-dict-key] Missing required key 'number_energy_price' in TypedDict `GridSourceType` constructor
- homeassistant/components/energy/data.py:804:20 error[missing-typed-dict-key] Missing required key 'number_energy_price_export' in TypedDict `GridSourceType` constructor
- homeassistant/components/energy/data.py:804:20 error[missing-typed-dict-key] Missing required key 'stat_compensation' in TypedDict `GridSourceType` constructor
- homeassistant/components/energy/data.py:804:20 error[missing-typed-dict-key] Missing required key 'stat_cost' in TypedDict `GridSourceType` constructor
- homeassistant/components/energy/data.py:804:20 error[missing-typed-dict-key] Missing required key 'stat_energy_from' in TypedDict `GridSourceType` constructor
- homeassistant/components/energy/data.py:804:20 error[missing-typed-dict-key] Missing required key 'stat_energy_to' in TypedDict `GridSourceType` constructor
- homeassistant/components/energy/data.py:804:20 error[missing-typed-dict-key] Missing required key 'type' in TypedDict `GridSourceType` constructor
- homeassistant/components/energy/data.py:804:20 error[invalid-return-type] Return type does not match returned value: expected `GridSourceType`, found `dict[str, Unknown | str]`
- homeassistant/components/energy/data.py:807:16 error[missing-typed-dict-key] Missing required key 'cost_adjustment_day' in TypedDict `GridSourceType` constructor
- homeassistant/components/energy/data.py:807:16 error[missing-typed-dict-key] Missing required key 'entity_energy_price' in TypedDict `GridSourceType` constructor
- homeassistant/components/energy/data.py:807:16 error[missing-typed-dict-key] Missing required key 'entity_energy_price_export' in TypedDict `GridSourceType` constructor
- homeassistant/components/energy/data.py:807:16 error[missing-typed-dict-key] Missing required key 'number_energy_price' in TypedDict `GridSourceType` constructor
- homeassistant/components/energy/data.py:807:16 error[missing-typed-dict-key] Missing required key 'number_energy_price_export' in TypedDict `GridSourceType` constructor
- homeassistant/components/energy/data.py:807:16 error[missing-typed-dict-key] Missing required key 'stat_compensation' in TypedDict `GridSourceType` constructor
- homeassistant/components/energy/data.py:807:16 error[missing-typed-dict-key] Missing required key 'stat_cost' in TypedDict `GridSourceType` constructor
- homeassistant/components/energy/data.py:807:16 error[missing-typed-dict-key] Missing required key 'stat_energy_from' in TypedDict `GridSourceType` constructor
- homeassistant/components/energy/data.py:807:16 error[missing-typed-dict-key] Missing required key 'stat_energy_to' in TypedDict `GridSourceType` constructor
- homeassistant/components/energy/data.py:807:16 error[missing-typed-dict-key] Missing required key 'type' in TypedDict `GridSourceType` constructor
- homeassistant/components/energy/data.py:807:16 error[invalid-return-type] Return type does not match returned value: expected `GridSourceType`, found `dict[str, Unknown | str]`

pyjwt (https://github.com/jpadilla/pyjwt)
- jwt/api_jwt.py:88:16 error[missing-typed-dict-key] Missing required key 'enforce_minimum_key_length' in TypedDict `FullOptions` constructor
- jwt/api_jwt.py:88:16 error[missing-typed-dict-key] Missing required key 'require' in TypedDict `FullOptions` constructor
- jwt/api_jwt.py:88:16 error[missing-typed-dict-key] Missing required key 'strict_aud' in TypedDict `FullOptions` constructor
- jwt/api_jwt.py:88:16 error[missing-typed-dict-key] Missing required key 'verify_aud' in TypedDict `FullOptions` constructor
- jwt/api_jwt.py:88:16 error[missing-typed-dict-key] Missing required key 'verify_exp' in TypedDict `FullOptions` constructor
- jwt/api_jwt.py:88:16 error[missing-typed-dict-key] Missing required key 'verify_iat' in TypedDict `FullOptions` constructor
- jwt/api_jwt.py:88:16 error[missing-typed-dict-key] Missing required key 'verify_iss' in TypedDict `FullOptions` constructor
- jwt/api_jwt.py:88:16 error[missing-typed-dict-key] Missing required key 'verify_jti' in TypedDict `FullOptions` constructor
- jwt/api_jwt.py:88:16 error[missing-typed-dict-key] Missing required key 'verify_nbf' in TypedDict `FullOptions` constructor
- jwt/api_jwt.py:88:16 error[missing-typed-dict-key] Missing required key 'verify_signature' in TypedDict `FullOptions` constructor
- jwt/api_jwt.py:88:16 error[missing-typed-dict-key] Missing required key 'verify_sub' in TypedDict `FullOptions` constructor
- jwt/api_jwt.py:88:16 error[invalid-return-type] Return type does not match returned value: expected `FullOptions`, found `dict[str, Unknown]`

Full report with detailed diff (timing results)

codspeed-hq · 2026-04-17T23:30:39Z

Merging this PR will degrade performance by 4.59%

❌ 1 regressed benchmark
✅ 46 untouched benchmarks
⏩ 60 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
❌	WallTime	`pydantic`	7.8 s	8.1 s	-4.59%

_{Comparing charlie/unpack-literal (10f4c9a) with main (67296f0)}

60 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

sharkdp

Thank you

astral-sh-bot Bot added the ty Multi-file analysis & type inference label Apr 17, 2026

charliermarsh changed the title ~~[ty] Support **TypedDict unpacking in dict-literal assignments~~ [ty] Support ** unpacking of TypedDict in dict-literal assignments Apr 17, 2026

charliermarsh marked this pull request as ready for review April 18, 2026 03:03

charliermarsh requested review from AlexWaygood, carljm, dcreager, ibraheemdev and sharkdp as code owners April 18, 2026 03:03

astral-sh-bot Bot assigned sharkdp Apr 18, 2026

charliermarsh marked this pull request as draft April 18, 2026 19:13

[ty] Support **TypedDict unpacking in dict-literal assignments

10f4c9a

charliermarsh marked this pull request as ready for review April 18, 2026 23:55

charliermarsh force-pushed the charlie/unpack-literal branch from 7b49ce5 to 10f4c9a Compare April 19, 2026 00:36

carljm removed their request for review April 19, 2026 04:11

sharkdp approved these changes Apr 22, 2026

View reviewed changes

charliermarsh merged commit ae613c5 into main Apr 22, 2026
55 of 56 checks passed

charliermarsh deleted the charlie/unpack-literal branch April 22, 2026 15:11

This was referenced Apr 27, 2026

Always include panic payload in panic diagnostic message #24873

Merged

ASCII identifier fast path #24876

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ty] Support `**` unpacking of `TypedDict` in dict-literal assignments#24703

[ty] Support `**` unpacking of `TypedDict` in dict-literal assignments#24703
charliermarsh merged 1 commit intomainfrom
charlie/unpack-literal

charliermarsh commented Apr 17, 2026

Uh oh!

astral-sh-bot Bot commented Apr 17, 2026 •

edited

Loading

Uh oh!

astral-sh-bot Bot commented Apr 17, 2026 •

edited

Loading

Uh oh!

astral-sh-bot Bot commented Apr 17, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Apr 17, 2026 •

edited

Loading

Uh oh!

sharkdp left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

charliermarsh commented Apr 17, 2026

Summary

Uh oh!

astral-sh-bot Bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Typing conformance results

No changes detected ✅

Uh oh!

astral-sh-bot Bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Memory usage report

Uh oh!

astral-sh-bot Bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ecosystem-analyzer results

Uh oh!

codspeed-hq Bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will degrade performance by 4.59%

Performance Changes

Footnotes

Uh oh!

sharkdp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

astral-sh-bot Bot commented Apr 17, 2026 •

edited

Loading

astral-sh-bot Bot commented Apr 17, 2026 •

edited

Loading

astral-sh-bot Bot commented Apr 17, 2026 •

edited

Loading

`ecosystem-analyzer` results

codspeed-hq Bot commented Apr 17, 2026 •

edited

Loading