H50 and T9 led , display and other overlays update

[gpaesano]

Description

The followings:
patch/kernel/archive/rockchip64-6.12/overlay/rockchip-rk3318-box-led-conf6.dtso
patch/kernel/archive/rockchip64-6.12/overlay/rockchip-rk3318-box-led-conf7.dtso

patch/kernel/archive/rockchip64-6.18/overlay/rockchip-rk3318-box-led-conf6.dtso
patch/kernel/archive/rockchip64-6.18/overlay/rockchip-rk3318-box-led-conf7.dtso

have been updated. Overlays for 6.18 should be compatibile with more recent versions, not tested yet.

Documentation summary for feature / change

for the H50 (led-conf6) :
fixed indexing of the display array
added compatible "titanmec,tm1650" to correctly enable the display
added working and ir-led
added boot-on regulator to properly switch on the HDMI port

for the T9 (led-conf7)
using compatible = "fdhisi,fd6551" - according to the actual chip
display index rearranged accordingly

GitHub issue reference:
Jira reference number [AR-9999]

• short description (copy / paste of PR title)
• summary (description relevant for end users)
• example of usage (how to see this in function)

How Has This Been Tested?

Built and tested

• [x ] Test A linux 6.12
• [x ] Test B linux 6.18

Checklist:

Please delete options that are not relevant.

• My code follows the style guidelines of this project
• [ x] I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• [x ] My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• New Features
  • Added improved LED indicators for working status, infrared, storage activity, LAN link, USB, colon, and WLAN activity.
  • Added reliable HDMI 5V power control with automatic startup behavior.
  • Improved LAN link status reporting through automatic indicator activation.
  • Updated display compatibility, brightness handling, digit mappings, and indicator assignments.
  • Refined device identification for T9 RK3318/RK3328 variants.
  • Enhanced indicator behavior and display output across supported hardware configurations.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Changes

The RK3318 overlays now define GPIO LEDs, updated display-controller bindings and mappings, LAN link triggers, RK3328 variant metadata, and GPIO-controlled HDMI VBUS regulators for kernels 6.12, 6.18, and 7.1.

RK3318 overlay updates

Layer / File(s)	Summary
Indicator and display configuration patch/kernel/archive/rockchip64-6.12/overlay/rockchip-rk3318-box-led-conf6.dtso, patch/kernel/archive/rockchip64-6.12/overlay/rockchip-rk3318-box-led-conf7.dtso, patch/kernel/archive/rockchip64-6.18/overlay/rockchip-rk3318-box-led-conf6.dtso, patch/kernel/archive/rockchip64-6.18/overlay/rockchip-rk3318-box-led-conf7.dtso, patch/kernel/archive/rockchip64-7.1/overlay/rockchip-rk3318-box-led-conf6.dtso, patch/kernel/archive/rockchip64-7.1/overlay/rockchip-rk3318-box-led-conf7.dtso	Added GPIO LED definitions and LAN link triggers. Updated display compatibility strings, digit and segment mappings, display LED indices, and unavailable working LED nodes.
HDMI VBUS regulator patch/kernel/archive/rockchip64-6.12/overlay/rockchip-rk3318-box-led-conf6.dtso, patch/kernel/archive/rockchip64-6.18/overlay/rockchip-rk3318-box-led-conf6.dtso, patch/kernel/archive/rockchip64-7.1/overlay/rockchip-rk3318-box-led-conf6.dtso	Disabled the existing host VBUS regulator and added GPIO-controlled, always-on, boot-enabled 5V HDMI VBUS regulators.
RK3328 variant overlay patch/kernel/archive/rockchip64-6.12/overlay/rockchip-rk3318-box-led-conf7.dtso, patch/kernel/archive/rockchip64-6.18/overlay/rockchip-rk3318-box-led-conf7.dtso, patch/kernel/archive/rockchip64-7.1/overlay/rockchip-rk3318-box-led-conf7.dtso	Updated the T9 board descriptions for RK3328/RK3318 variants and added disabled working LED nodes where applicable.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: igorpecovnik, rpardini, heymeco, superkali

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the overlay updates for H50 and T9, including LED and display changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[EvilOlaf]

what about 7.1 and 7.2?

[gpaesano]

what about 7.1 and 7.2?

6.18 overlays should be fine with 7.1 and 7.2 but I did not test them yet. In any case the current version is a copy of the 6.18

[igorpecovnik]

Prepare them for 7.1 / 7.2 even untested

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@patch/kernel/archive/rockchip64-6.12/overlay/rockchip-rk3318-box-led-conf6.dtso`:
- Line 80: Remove the unsupported enable-active-low property from both overlay
files:
patch/kernel/archive/rockchip64-6.12/overlay/rockchip-rk3318-box-led-conf6.dtso
lines 80-80 and
patch/kernel/archive/rockchip64-6.18/overlay/rockchip-rk3318-box-led-conf6.dtso
lines 113-113. Leave active-low behavior represented by omitting
enable-active-high, then run device-tree schema validation.

In
`@patch/kernel/archive/rockchip64-6.18/overlay/rockchip-rk3318-box-led-conf7.dtso`:
- Line 9: Update the T9 overlay’s device-tree fragment to override the inherited
working LED node and set its status to disabled, matching the 6.12 peer overlay.
Ensure the base timer-triggered GPIO2_C7 LED is inactive at boot.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 786a7636-1a01-4939-9a8a-c9254779a166

📥 Commits

Reviewing files that changed from the base of the PR and between 8b778f3 and 4126840.

📒 Files selected for processing (4)

• patch/kernel/archive/rockchip64-6.12/overlay/rockchip-rk3318-box-led-conf6.dtso
• patch/kernel/archive/rockchip64-6.12/overlay/rockchip-rk3318-box-led-conf7.dtso
• patch/kernel/archive/rockchip64-6.18/overlay/rockchip-rk3318-box-led-conf6.dtso
• patch/kernel/archive/rockchip64-6.18/overlay/rockchip-rk3318-box-led-conf7.dtso

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@patch/kernel/archive/rockchip64-7.1/overlay/rockchip-rk3318-box-led-conf6.dtso`:
- Around line 47-64: Update the reg properties in the digit nodes to use
zero-based values matching their digit indices: digit@0 through digit@3 must use
reg values 0 through 3, respectively. Leave the segments mappings unchanged.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ad8b19dd-0c5f-4b41-89b4-f14e1f327fe7

📥 Commits

Reviewing files that changed from the base of the PR and between 0d433fd and 82ce82c.

📒 Files selected for processing (2)

• patch/kernel/archive/rockchip64-6.18/overlay/rockchip-rk3318-box-led-conf7.dtso
• patch/kernel/archive/rockchip64-7.1/overlay/rockchip-rk3318-box-led-conf6.dtso