fix(apollo-tools): add undeclared peer dependency graphql#2049
Merged
trevor-scheer merged 4 commits intoapollographql:masterfrom Mar 29, 2022
Merged
fix(apollo-tools): add undeclared peer dependency graphql#2049trevor-scheer merged 4 commits intoapollographql:masterfrom
trevor-scheer merged 4 commits intoapollographql:masterfrom
Conversation
|
@merceyz: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
moam87moodi
approved these changes
Jul 29, 2020
3 tasks
|
Any update on this? |
moam87moodi
approved these changes
Nov 15, 2020
Contributor
Author
|
@brandonchinn178 Since this wasn't merged "fast enough" I added this to the compat table in yarnpkg/berry#1847 so Yarn applies this automatically, it was released in 2.3.0 |
|
oh I see. I misread the error; I'm having problems with |
2142f5b to
08126dd
Compare
Contributor
|
Sorry this was never looked at! Going to merge and get this fix released. |
3 tasks
Contributor
Author
|
No worries, that's what we have the compat plugin for 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@apollographql/apollo-toolsis usinggraphqlwithout declaring it as a dependency, this causes issues under strict dependency environments (Yarn PnP) and causes it to rely on hoisting to hopefully place it in a accessible location which is not guaranteed.Fixes #1680
TODO: