Add missing graphql dependency#2062
Closed
oliversalzburg wants to merge 1 commit intoapollographql:masterfrom
oliversalzburg:fix/dependencies
Closed
Add missing graphql dependency#2062oliversalzburg wants to merge 1 commit intoapollographql:masterfrom oliversalzburg:fix/dependencies
oliversalzburg wants to merge 1 commit intoapollographql:masterfrom
oliversalzburg:fix/dependencies
Conversation
|
@oliversalzburg: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
Contributor
|
Already done in #2049 but it hasn't been merged yet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the dependency is currently not declared, users will see the following error in a yarn2/PnP installation:
(node:4310) [MODULE_NOT_FOUND] Error: @apollographql/apollo-tools tried to access graphql, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.As the error indicates, the module code does import code from
graphql, but the module manifest does not declare the dependency. This change fixes that.