Skip to content

Refactor MNG-11133 test to use maven-it-plugin-expression #12502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnodet wants to merge 1 commit into
base: master
Choose a base branch
from
+33 −7
Open

Refactor MNG-11133 test to use maven-it-plugin-expression #12502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng11133MixinsPrecedenceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@
*/
package org.apache.maven.it;

import java.nio.file.Files;
import java.nio.file.Path;
import java.util.Properties;

import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.assertEquals;

/**
* MNG-11133: Mixins should override properties inherited from parent.
Expand All @@ -37,13 +37,15 @@ public void testMixinOverridesParentProperty() throws Exception {
Verifier verifier = newVerifier(testDir);
verifier.setAutoclean(false);
verifier.deleteDirectory("target");
verifier.addCliArgument("help:effective-pom");
verifier.addCliArgument("-Doutput=target/effective-pom.xml");
verifier.addCliArgument("validate");
verifier.execute();
verifier.verifyErrorFreeLog();

verifier.verifyFilePresent("target/effective-pom.xml");
String effectivePom = Files.readString(testDir.resolve("target/effective-pom.xml"));
assertTrue(effectivePom.contains("<maven.compiler.release>21</maven.compiler.release>"));
verifier.verifyFilePresent("target/model.properties");
Properties props = verifier.loadProperties("target/model.properties");
assertEquals(
"21",
props.getProperty("project.properties.maven.compiler.release"),
"Property from mixin should override the parent's value");
}
}
24 changes: 24 additions & 0 deletions its/core-it-suite/src/test/resources/mng-11133-mixins/project/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,30 @@ under the License.
<artifactId>project</artifactId>
<version>1.0</version>

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.its.plugins</groupId>
<artifactId>maven-it-plugin-expression</artifactId>
<version>2.1-SNAPSHOT</version>
<executions>
<execution>
<goals>
<goal>eval</goal>
</goals>
<phase>validate</phase>
<configuration>
<outputFile>target/model.properties</outputFile>
<expressions>
<expression>project/properties</expression>
</expressions>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>

<mixins>
<mixin>
<relativePath>../mixins/mixin.xml</relativePath>
Expand Down
Loading