Refactor MNG-11133 test to use maven-it-plugin-expression#12502
Open
gnodet wants to merge 1 commit into
Open
Conversation
…ng in MNG-11133 test Replace help:effective-pom + Files.readString/String.contains with the conventional maven-it-plugin-expression approach using verifier.loadProperties(), which is more robust against whitespace/formatting changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
marked this pull request as ready for review
July 17, 2026 10:00
gnodet
commented
Jul 17, 2026
gnodet
left a comment
Contributor
Author
There was a problem hiding this comment.
AI Review — PR #12502
Verdict: ✅ LGTM (own PR, posting as COMMENT)
Clean refactoring from help:effective-pom string matching to the conventional maven-it-plugin-expression + loadProperties() + assertEquals() approach. Same pattern used by 30+ tests in core-it-suite and applied in PR #12461 for MNG-8432.
What I Appreciate
- Stronger assertion —
assertEquals("21", ...)checks the exact resolved property value rather than substring-matching raw XML, making the test both more precise and more resilient to formatting changes. - Self-documenting failure message —
"Property from mixin should override the parent's value"immediately tells a developer what went wrong. - Clean import hygiene — removed
FilesandassertTrue(no longer needed), addedPropertiesandassertEquals, no dead imports.
Findings
None — textbook refactoring. Same behavior, better implementation. ✨
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of Guillaume Nodet
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Jul 17, 2026
Review posted for apache#12502 (MNG-11133 test refactoring). Own PR, LGTM. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
help:effective-pom+Files.readString()+String.contains()with the conventionalmaven-it-plugin-expressionapproach usingverifier.loadProperties()inMavenITmng11133MixinsPrecedenceTestMavenITmng8432MixinsPropertiesTest— more robust against whitespace/formatting changes in effective POM XMLpom.xmlto evaluateproject/propertiesat thevalidatephaseTest plan
MavenITmng11133MixinsPrecedenceTestpasses locally (1 test, 0 failures)🤖 Generated with Claude Code