Skip to content

Fix stale block size comments in Lucene104 postings reader/writer #16491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vukasin-djuricic wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Fix stale block size comments in Lucene104 postings reader/writer #16491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lucene/core/src/java/org/apache/lucene/codecs/lucene104/Lucene104PostingsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,7 @@ private void refillFullBlock() throws IOException {
int numLongs;
if (bitsPerValue == 0) {
// 0 is used to record that all 256 docs in the block are consecutive
numLongs = BLOCK_SIZE / Long.SIZE; // 2
numLongs = BLOCK_SIZE / Long.SIZE; // 4
docBitSet.set(0, BLOCK_SIZE);
} else {
numLongs = -bitsPerValue;
Expand Down
4 changes: 2 additions & 2 deletions lucene/core/src/java/org/apache/lucene/codecs/lucene104/Lucene104PostingsWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ private void flushDocBlock(boolean finishTerm) throws IOException {
spareBitSet.set(s);
}
// We never use the bit set encoding when it requires more than Integer.SIZE=32 bits per
// value. So the bit set cannot have more than BLOCK_SIZE * Integer.SIZE / Long.SIZE = 64
// value. So the bit set cannot have more than BLOCK_SIZE * Integer.SIZE / Long.SIZE = 128
// longs, which fits on a byte.
assert numBitSetLongs <= BLOCK_SIZE / 2;
level0Output.writeByte((byte) -numBitSetLongs);
Expand Down Expand Up @@ -483,7 +483,7 @@ private void flushDocBlock(boolean finishTerm) throws IOException {
level0FreqNormAccumulator.clear();
}

if ((docCount & LEVEL1_MASK) == 0) { // true every 32 blocks (4,096 docs)
if ((docCount & LEVEL1_MASK) == 0) { // true every 32 blocks (8,192 docs)
writeLevel1SkipData();
level1LastDocID = docID;
level1CompetitiveFreqNormAccumulator.clear();
Expand Down
Loading