Fix stale block size comments in Lucene104 postings reader/writer - #16491
Open
vukasin-djuricic wants to merge 1 commit into
Open
Fix stale block size comments in Lucene104 postings reader/writer#16491vukasin-djuricic wants to merge 1 commit into
vukasin-djuricic wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15670.
BLOCK_SIZE went from 128 to 256 in 10.4, but a few comments still spell out
values computed with the old block size:
is 8,192 docs, not 4,096.
The assert on the next line already uses BLOCK_SIZE / 2.
This is a follow-up to #15672, where the question was raised whether other
comments needed the same fix. I went through the lucene104 package looking
for comments that hard-code values derived from BLOCK_SIZE, and these three
are the only ones left. The version history in package-info.java is correct
as is, since it describes the 9.12 format where BLOCK_SIZE was still 128.
Documentation only, no change in behaviour, so no CHANGES.txt entry.