Skip to content

feat(req): port of reqsketch-rs #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pmcgleenon wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(req): port of reqsketch-rs #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f15ec54
feat(req): port REQ sketch from reqsketch-rs
pmcgleenon May 30, 2026
1f27cd6
feat(req): cargo +nightly fmt --all
pmcgleenon Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
187 changes: 186 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,13 @@ rust-version = "1.86.0"
datasketches = { path = "datasketches" }

# Crates.io dependencies
approx = { version = "0.5" }
clap = { version = "4.6.5", features = ["derive"] }
insta = { version = "1.48.0" }
googletest = { version = "0.14.3" }
insta = { version = "1.48.0" }
cargo_metadata = { version = "0.23.1" }
proptest = { version = "1" }
rand = { version = "0.9.2" }
which = { version = "8.0.5" }
flate2 = { version = "1.1.9", default-features = false, features = ["zlib-rs"] }
tar = { version = "0.4.46", default-features = false }
Expand Down
11 changes: 11 additions & 0 deletions datasketches/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ countmin = []
cpc = []
frequencies = []
hll = []
req = ["dep:rand"]
tdigest = []
theta = []
tuple = []
Expand Down Expand Up @@ -72,6 +73,11 @@ name = "hll_test"
path = "tests/hll_test/main.rs"
required-features = ["hll"]

[[test]]
name = "req_test"
path = "tests/req_test/main.rs"
required-features = ["req"]

[[test]]
name = "tdigest_test"
path = "tests/tdigest_test/main.rs"
Expand All @@ -87,9 +93,14 @@ name = "tuple_test"
path = "tests/tuple_test/main.rs"
required-features = ["tuple"]

[dependencies]
rand = { workspace = true, optional = true }
Comment on lines +96 to +97

@tisonkun tisonkun Aug 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be relevant to #203.

cc @jeffoodchain

We may use rand as a starting point and conclude before the next release.


[dev-dependencies]
approx = { workspace = true }

@tisonkun tisonkun Aug 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

googletest provides:

.. and we may need one more test lib. But you can leave it to me to do a global alignment.

googletest = { workspace = true }
insta = { workspace = true }
proptest = { workspace = true }

[lints]
workspace = true
9 changes: 9 additions & 0 deletions datasketches/src/codec/family.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,15 @@ impl Family {
max_pre_longs: 5,
};

/// Relative Error Quantiles (REQ) sketch.
#[cfg(feature = "req")]
pub const REQ: Family = Family {
id: 17,
name: "REQ",
min_pre_longs: 2,
max_pre_longs: 4,
Comment on lines +88 to +89

@tisonkun tisonkun Aug 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From datasketches-java, these fields are:

REQ(17, "REQ", 1 /* minPreLongs */, 2 /* maxPreLongs */),

But we don't use these fields for REQSketch anyway.

};

/// CountMin Sketch
#[cfg(feature = "countmin")]
pub const COUNTMIN: Family = Family {
Expand Down
2 changes: 2 additions & 0 deletions datasketches/src/codec/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ pub use self::encode::SketchBytes;
feature = "cpc",
feature = "frequencies",
feature = "hll",
feature = "req",
feature = "tdigest",
feature = "theta",
feature = "tuple",
Expand All @@ -41,6 +42,7 @@ pub(crate) mod assert;
feature = "cpc",
feature = "frequencies",
feature = "hll",
feature = "req",
feature = "tdigest",
feature = "theta",
feature = "tuple",
Expand Down
2 changes: 2 additions & 0 deletions datasketches/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ pub mod cpc;
pub mod frequencies;
#[cfg(feature = "hll")]
pub mod hll;
#[cfg(feature = "req")]
pub mod req;
#[cfg(feature = "tdigest")]
pub mod tdigest;
#[cfg(any(feature = "theta", feature = "tuple"))]
Expand Down
Loading