Skip to content

feat(req): port of reqsketch-rs - #204

Open
pmcgleenon wants to merge 2 commits into
apache:mainfrom
pmcgleenon:feat-req
Open

feat(req): port of reqsketch-rs #204
pmcgleenon wants to merge 2 commits into
apache:mainfrom
pmcgleenon:feat-req

Conversation

@pmcgleenon

Copy link
Copy Markdown

This is a port of reqsketch-rs as discussed here #90. This implementation is influenced heavily by the apache datasketches C++ implementation.

Some things present in reqsketch-rs that are not part of this PR:

  • benchmarks, I left these out since I didn't see any other benchmarks. Maybe we can add some in a later PR for all the sketches
  • program build the plots rank error plots. There are a bunch of dependencies needed for this so I left it out. But I think it's a great visualization of the reqsketch algorithm and helps with validation of the results since the apache-datasketches project has similar plots and they can be easily compared to validate the results

@tisonkun FYI if you get a chance please take a look

@pmcgleenon pmcgleenon changed the title REQ sketch : port of reqsketch-rs feat REQ sketch : port of reqsketch-rs Aug 18, 2026
@tisonkun tisonkun changed the title feat REQ sketch : port of reqsketch-rs feat: REQ sketch port of reqsketch-rs Aug 18, 2026
@pmcgleenon pmcgleenon changed the title feat: REQ sketch port of reqsketch-rs feat: REQ sketch : port of reqsketch-rs Aug 18, 2026
@tisonkun tisonkun changed the title feat: REQ sketch : port of reqsketch-rs feat(req): port of reqsketch-rs Aug 18, 2026

@tisonkun tisonkun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @pmcgleenon! I'll review this patch in this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants