add driver for ad5710r/ad5711r#3191
Open
kseerp wants to merge 3 commits into
Open
Conversation
kseerp
requested review from
CiprianRegus,
amiclaus,
btogorean,
buha,
chegbeli,
danmois,
dbogdan,
machschmitt,
mhennerich,
nunojsa,
rbolboac and
stefpopa
as code owners
Collaborator
|
is this targetting upstream? if so, can you target a mirroc_ci branch? |
8 tasks
gastmaier
reviewed
Mar 25, 2026
Comment on lines
+763
to
+764
| three_state: left floating, | ||
| high_z: left floating. |
Collaborator
There was a problem hiding this comment.
What is the difference between three_state and high_z ? max5821 uses three_state
Member
Author
There was a problem hiding this comment.
I think the difference is naming convention. Voltage DAC like max5821 describe the powered-down output as tri-state, while current DAC like the ad5710R describe it as high impedance. I used high_z here to match the AD5710R datasheet terminology. That said, both are defined as left floating in the IIO ABI. Should I just use three_state instead for consistency with existing DAC drivers?
Collaborator
kseerp
force-pushed
the
dev/ad5710r
branch
2 times, most recently
from
37b5e11 to
80469f8
Compare
Member
Author
|
rebase to |
gastmaier
force-pushed
the
mirror_ci/jic23/iio/testing
branch
7 times, most recently
from
5d18d61 to
353fec2
Compare
gastmaier
force-pushed
the
mirror_ci/jic23/iio/testing
branch
7 times, most recently
from
c2f48c4 to
d16d458
Compare
gastmaier
force-pushed
the
mirror_ci/jic23/iio/testing
branch
6 times, most recently
from
55ab0e3 to
90f0e0f
Compare
kseerp
force-pushed
the
dev/ad5710r
branch
2 times, most recently
from
0c53448 to
fa2929b
Compare
Member
Author
|
v3
|
gastmaier
force-pushed
the
mirror_ci/jic23/iio/testing
branch
6 times, most recently
from
dcbb031 to
5fd28f8
Compare
Member
Author
|
Hi, just following up on this PR, are there any changes still needed, or is this good to go upstream? It seems CI failing are unrelated to this PR. |
gastmaier
force-pushed
the
mirror_ci/jic23/iio/testing
branch
3 times, most recently
from
1567260 to
fab5a96
Compare
Add high_z powerdown mode for DACs with high impedance output in current mode (IDAC) and 15kohm_to_gnd resistor to GND. Also add out_currentY_powerdown_mode, out_currentY_powerdown_mode_available, and out_currentY_powerdown entries to document current output powerdown support. Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
Add device tree bindings for the Analog Devices AD5710R/AD5711R 8-channel 12-/16-bit Configurable IDAC/VDAC. Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
The AD5710R (16-bit) and AD5711R (12-bit) are 8-channel, low-power, configurable current/voltage output DACs with an on-chip 2.5V, 3ppm/°C reference. Each channel can be independently configured as a voltage output (0V to VREF or 0V to 2xVREF) or a current output (0mA to 50mA). These devices operate from a single 2.7V to 5.5V supply and are guaranteed monotonic by design. Support for monitoring internal die temperature, output voltages, and current of a selected channel via the MUXOUT pin using an external ADC is currently not implemented. Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds support for the AD5710R (16-bit) and AD5711R (12-bit) 8-channel configurable IDAC/VDAC.
Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ad5711r-ad5710r.pdf
The AD5710R/AD5711R shares a similar register interface with the
AD3530R family but introduces current output (IDAC) support alongside
voltage output (VDAC), independently configurable per channel. This
brings additional complexity in channel mode configuration and
powerdown handling (high_z for IMODE, 15kohm_to_gnd for VMODE).
Rather than extending the AD3530R driver - which is already growing
in complexity with AD3532R dual-bank support (#3177) - this is
introduced as a dedicated driver.
Looking for feedback on whether keeping this as a separate driver is
the right approach, or if it should be folded into the AD3530R driver.
PR Type
PR Checklist