Clang tidy add extra arg option and return 1 when any error is catched.#452
Open
wuisky wants to merge 4 commits intoament:rollingfrom
Open
Clang tidy add extra arg option and return 1 when any error is catched.#452wuisky wants to merge 4 commits intoament:rollingfrom
wuisky wants to merge 4 commits intoament:rollingfrom
Conversation
wuisky
force-pushed
the
clang-tidy-add-extra-arg-option
branch
from
8e87eb1 to
15d5c2c
Compare
This was referenced Oct 18, 2023
wuisky
force-pushed
the
clang-tidy-add-extra-arg-option
branch
2 times, most recently
from
a3e92af to
6959c91
Compare
Signed-off-by: WU MENGHUNG <wu.menghung@jp.panasonic.com>
Signed-off-by: WU MENGHUNG <wu.menghung@jp.panasonic.com>
Signed-off-by: WU MENGHUNG <wu.menghung@jp.panasonic.com>
wuisky
force-pushed
the
clang-tidy-add-extra-arg-option
branch
from
6959c91 to
6210f2f
Compare
wuisky
force-pushed
the
clang-tidy-add-extra-arg-option
branch
from
8285481 to
6210f2f
Compare
…-add-extra-arg-option
|
A gentle ping since this is a particularly important update to let Cheers, Niccolo |
Author
|
@clalancette could you take a look of this PR? |
|
This would be a great improvement, making |
|
Is there any update on that? Without that, running ament_clang_tidy in CI is not useful, since it will always pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there. Thank you for developing such nice tool.
However, i noticed that rclcpp use some c++17 features,
and without passing --extra-arg=-std=c++17 to clang-tidy it will report errors in these headers.
After this patch, we can pass extra-arg just like:
Also, i fix issues mentioned in #350 #411.
Hope this helps.