Skip to content

clang-tidy: exclude protobuf sources#457

Open
patrick-5546 wants to merge 3 commits intoament:rollingfrom
patrick-5546:exclude-protobuf
Open

clang-tidy: exclude protobuf sources#457
patrick-5546 wants to merge 3 commits intoament:rollingfrom
patrick-5546:exclude-protobuf

Conversation

@patrick-5546
Copy link
Copy Markdown

No description provided.

Signed-off-by: Patrick Creighton <pcreighton429@gmail.com>
Signed-off-by: Patrick Creighton <pcreighton429@gmail.com>
@sloretz
Copy link
Copy Markdown
Contributor

sloretz commented Nov 2, 2023

This is a nice small PR. Would you be willing to implement it using AMENT_LINT_AUTO_FILE_EXCLUDE instead? (context: #386). That will allow you to filter generated protobuf files at the package level, and also help resolve #458.

Signed-off-by: Patrick Creighton <pcreighton429@gmail.com>
@patrick-5546
Copy link
Copy Markdown
Author

patrick-5546 commented Nov 4, 2023

@sloretz I haven't extensively tested it yet, but does this look something like what you are looking for? I mainly based it off of cpplint's implementation

@patrick-5546
Copy link
Copy Markdown
Author

@asymingt
Copy link
Copy Markdown
Member

Hey @sloretz this came up in the ROS Waffle meeting. Is there anything blocking approval and merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants