Repository navigation
fix(deps): patch transitive undici, fast-uri, brace-expansion, and cache advisories - #305
Draft
amanthanvi wants to merge 1 commit into
Draft
amanthanvi wants to merge 1 commit into
amanthanvi wants to merge 1 commit into
Conversation
…che advisories Raise the vulnerable override pins (undici 6.28.0, fast-uri 3.1.6, brace-expansion 1.1.18 / 5.0.9) to their patched releases and floor http-cache-semantics at 4.3.0 and source-map-js at 1.2.2. pnpm audit drops from 15 findings (10 high) to one: braces <=3.0.3 has no fixed release and is only reachable through the Vercel CLI's ts-morph tooling. Co-authored-by: Aman Thanvi <amanthanvi@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis dependency-maintenance PR updates pnpm workspace overrides so vulnerable transitive packages resolve to patched versions across the Vercel CLI, Sigstore, and Tailwind dependency trees, regenerates the focused lockfile changes, and documents the single remaining advisory without a fix. Flow diagram for dependency advisory remediationflowchart TD
Audit[pnpm audit reports vulnerable transitive packages] --> Overrides[Raise pnpm workspace override floors]
Overrides --> Lockfile[Regenerate focused lockfile]
Lockfile --> Patched[Five dependency families resolve to patched versions]
Patched --> Verify[Run dependency provenance and project checks]
Verify --> Remaining[One unfixed braces advisory remains]
Remaining --> Document[Document remaining advisory in CHANGELOG]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Raises the
pnpm-workspace.yamloverride pins that are now vulnerable, and adds floors for two packages:vercel>undicivercel>…>ajv>fast-urivercel>…>ts-morph,sigstore>…>globsigstore>…>make-fetch-happennextjs>@tailwindcss/postcss>…The lockfile diff is 66 lines and only touches these packages.
Why
pnpm auditon main reports 15 findings (10 high, 4 moderate, 1 low), all from advisories published September 18–29. Most sit behind existing exact override pins, which Dependabot can't move, so no Dependabot PR was opened for them. I found this while checking the Next.js/sharp advisories for #299. Those two are already patched on main (next@16.3.8,sharp@0.35.5).After this change
pnpm auditreports one finding:braces≤3.0.3 (GHSA-vfj7-8cjw-p6xm, high, stack-exhaustion DoS). It has no fixed release (3.0.3 is the latest), and it's only reachable through deploy tooling (vercel>@vercel/backends>ts-morph>@ts-morph/common>fast-glob>micromatch>braces), which processes trusted repository input. It's documented in the CHANGELOG rather than suppressed.Checklist
pnpm next:lint,pnpm next:grammar,pnpm next:test,pnpm convex:test,pnpm convex:typecheck,pnpm -C nextjs buildpnpm deps:provenance(Sigstore path with the bumped deps; verifiedvercel@58.4.4),pnpm ops:test,node scripts/check-osv-exceptions.mjs,vercel --version/vercel build --helpsmoke (same exit code as main)pnpm ingest:lint,pnpm ingest:test: not affectedCHANGELOG.mdupdated under UnreleasedSummary by Sourcery
Patch vulnerable transitive dependencies and reduce the remaining audit findings to an unfixed advisory in trusted Vercel tooling.
Bug Fixes:
Documentation:
bracesadvisory in the unreleased changelog.