chore: Cleanup and move grid_helper.hpp to MultiAxisHelper.hpp#5541
Merged
kodiakhq[bot] merged 8 commits intoJun 8, 2026
Merged
Conversation
github-actions
Bot
added
Component - Core
Contributor
paulgessinger
previously approved these changes
Jun 5, 2026
paulgessinger
left a comment
paulgessinger
left a comment
Member
There was a problem hiding this comment.
Technically breaking. Do we care?
Contributor
Author
I wanted this to only touch |
Collaborator
acts-project-service
added
the
Fails Athena tests
Member
|
@andiwand Ah I think I looked |
AJPfleger
reviewed
Jun 7, 2026
AJPfleger
reviewed
Jun 7, 2026
…p-rename-gridhelper
AJPfleger
reviewed
Jun 8, 2026
AJPfleger
approved these changes
Jun 8, 2026
andiwand
added
automerge
and removed
Fails Athena tests
|
madbaron
added a commit
to MuonColliderSoft/mucoll-spack
that referenced
this pull request
Jun 9, 2026
acts main HEAD (739072bb) fails to compile k4actstracking: the CylindricalSpacePointGrid fill path calls grid.atPosition(binIndex) with a std::size_t global-bin index, which after the 2026-06-08 grid refactor (acts-project/acts#5541, c36cd88cd) resolves to the position-lookup overload (Point = std::size_t). MultiAxisHelper then subscripts the scalar, giving "subscripted value is neither array nor pointer". Freeze acts@main to 0f9e9afe (parent of the breaking refactor, 2026-06-08) so the nightly stack builds. Revert to plain '@main' once acts main is fixed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jun 9, 2026
Closed
kodiakhq Bot
pushed a commit
that referenced
this pull request
Jun 9, 2026
Fix a faulty grid access after #5541
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grid_helpertoMultiAxisHelperipowtoMathHelpers.hppMultiAxisfromGrid#5531--- END COMMIT MESSAGE ---