Patch acts@main fillGrid atPosition->at to verify upstream fix#68
Merged
Conversation
acts main fails to compile k4actstracking: CylindricalSpacePointGrid.ipp's post-fill sort loop calls grid.atPosition(binIndex) with a std::size_t global bin index. After acts-project/acts#5541 (c36cd88cd) routed localBinsFromPosition through MultiAxisHelper::getMultiIndexFromPoint, that deduces Point=std::size_t and subscripts a scalar -> "subscripted value is neither array nor pointer". Rather than pinning acts, add a mucoll-namespace acts override that subclasses builtin acts and applies a one-line source patch (atPosition -> at, matching the grid.at(globIndex) accessor used a few lines above) when @main. This keeps acts tracking main while verifying the candidate upstream fix unblocks the build. Remove once the fix lands in acts main. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
acts main fails to compile k4actstracking: CylindricalSpacePointGrid.ipp's post-fill sort loop calls grid.atPosition(binIndex) with a std::size_t global bin index. After acts-project/acts#5541 (c36cd88cd) routed localBinsFromPosition through MultiAxisHelper::getMultiIndexFromPoint, that deduces Point=std::size_t and subscripts a scalar -> "subscripted value is neither array nor pointer".
Rather than pinning acts, add a mucoll-namespace acts override that subclasses builtin acts and applies a one-line source patch (atPosition -> at, matching the grid.at(globIndex) accessor used a few lines above) when @main. This keeps acts tracking main while verifying the candidate upstream fix unblocks the build. Remove once the fix lands in acts main.