-
Notifications
You must be signed in to change notification settings - Fork 631
UN-1009 [FIX] Correct LLMWhisperer adapter API key field label from 'Unstract Key' to 'LLMWhisperer Key' #2037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -22,7 +22,7 @@ | |||||
| }, | ||||||
| "unstract_key": { | ||||||
| "type": "string", | ||||||
| "title": "Unstract Key", | ||||||
| "title": "LLMWhisperer Key", | ||||||
| "format": "password", | ||||||
| "description": "API key obtained from the [Unstract developer portal](https://us-central.unstract.com/landing?selectedProduct=llm-whisperer)" | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: unstract/sdk1/src/unstract/sdk1/adapters/x2text/llm_whisperer_v2/src/static/json_schema.json
Line: 27
Comment:
Same pattern as in v1: the `title` now reads "LLMWhisperer Key" but the `description` still directs users to the "Unstract developer portal". The two fields are shown together in the adapter config form, so aligning the portal name keeps the messaging consistent.
```suggestion
"description": "API key obtained from the [LLMWhisperer portal](https://us-central.unstract.com/landing?selectedProduct=llm-whisperer)"
```
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! |
||||||
| }, | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
titlehas been correctly updated to "LLMWhisperer Key", but thedescriptionstill says "Unstract developer portal". For full consistency, the description could also be updated to name the LLMWhisperer portal explicitly — otherwise the label says "LLMWhisperer Key" while the help text directs users to an "Unstract" portal.Prompt To Fix With AI
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!