UN-1009 [FIX] Correct LLMWhisperer adapter API key field label from 'Unstract Key' to 'LLMWhisperer Key'#2037
UN-1009 [FIX] Correct LLMWhisperer adapter API key field label from 'Unstract Key' to 'LLMWhisperer Key'#2037athul-rs wants to merge 1 commit into
Conversation
…to 'LLMWhisperer Key' Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
athul-rs
requested review from
chandrasekharan-zipstack,
hari-kuriakose and
jaseemjaskp
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Summary by CodeRabbit
WalkthroughTwo JSON schema configuration files for the LLMWhisperer text extraction adapters update the user-facing display label for the ChangesSchema Field Label Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
| Filename | Overview |
|---|---|
| unstract/sdk1/src/unstract/sdk1/adapters/x2text/llm_whisperer/src/static/json_schema.json | Renames the display title of unstract_key from "Unstract Key" to "LLMWhisperer Key"; description still references "Unstract developer portal" which is slightly inconsistent with the new label |
| unstract/sdk1/src/unstract/sdk1/adapters/x2text/llm_whisperer_v2/src/static/json_schema.json | Renames the display title of unstract_key from "Unstract Key" to "LLMWhisperer Key"; description text also still reads "Unstract developer portal" |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[JSON Schema\njson_schema.json] -->|parsed by| B[Adapter Config UI]
B --> C[unstract_key field]
C --> D["title: 'LLMWhisperer Key'\n(was: 'Unstract Key')"]
C --> E["description:\n'API key from Unstract developer portal'\n(unchanged)"]
C --> F["format: password\ntype: string\n(unchanged)"]
D --> G[User sees 'LLMWhisperer Key'\nlabel in form]
E --> H[User sees portal\nlink in tooltip/help]
Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
unstract/sdk1/src/unstract/sdk1/adapters/x2text/llm_whisperer/src/static/json_schema.json:28
The `title` has been correctly updated to "LLMWhisperer Key", but the `description` still says "Unstract developer portal". For full consistency, the description could also be updated to name the LLMWhisperer portal explicitly — otherwise the label says "LLMWhisperer Key" while the help text directs users to an "Unstract" portal.
```suggestion
"description": "API key obtained from the [LLMWhisperer developer portal](https://unstract-api-resource.developer.azure-api.net)"
```
### Issue 2 of 2
unstract/sdk1/src/unstract/sdk1/adapters/x2text/llm_whisperer_v2/src/static/json_schema.json:27
Same pattern as in v1: the `title` now reads "LLMWhisperer Key" but the `description` still directs users to the "Unstract developer portal". The two fields are shown together in the adapter config form, so aligning the portal name keeps the messaging consistent.
```suggestion
"description": "API key obtained from the [LLMWhisperer portal](https://us-central.unstract.com/landing?selectedProduct=llm-whisperer)"
```
Reviews (1): Last reviewed commit: "UN-1009 Fix LLMWhisperer adapter key fie..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| "title": "Unstract Key", | ||
| "title": "LLMWhisperer Key", | ||
| "format": "password", | ||
| "description": "API key obtained from the [Unstract developer portal](https://unstract-api-resource.developer.azure-api.net)" |
There was a problem hiding this comment.
title has been correctly updated to "LLMWhisperer Key", but the description still says "Unstract developer portal". For full consistency, the description could also be updated to name the LLMWhisperer portal explicitly — otherwise the label says "LLMWhisperer Key" while the help text directs users to an "Unstract" portal.
| "description": "API key obtained from the [Unstract developer portal](https://unstract-api-resource.developer.azure-api.net)" | |
| "description": "API key obtained from the [LLMWhisperer developer portal](https://unstract-api-resource.developer.azure-api.net)" |
Prompt To Fix With AI
This is a comment left during a code review.
Path: unstract/sdk1/src/unstract/sdk1/adapters/x2text/llm_whisperer/src/static/json_schema.json
Line: 28
Comment:
The `title` has been correctly updated to "LLMWhisperer Key", but the `description` still says "Unstract developer portal". For full consistency, the description could also be updated to name the LLMWhisperer portal explicitly — otherwise the label says "LLMWhisperer Key" while the help text directs users to an "Unstract" portal.
```suggestion
"description": "API key obtained from the [LLMWhisperer developer portal](https://unstract-api-resource.developer.azure-api.net)"
```
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| "title": "Unstract Key", | ||
| "title": "LLMWhisperer Key", | ||
| "format": "password", | ||
| "description": "API key obtained from the [Unstract developer portal](https://us-central.unstract.com/landing?selectedProduct=llm-whisperer)" |
There was a problem hiding this comment.
title now reads "LLMWhisperer Key" but the description still directs users to the "Unstract developer portal". The two fields are shown together in the adapter config form, so aligning the portal name keeps the messaging consistent.
| "description": "API key obtained from the [Unstract developer portal](https://us-central.unstract.com/landing?selectedProduct=llm-whisperer)" | |
| "description": "API key obtained from the [LLMWhisperer portal](https://us-central.unstract.com/landing?selectedProduct=llm-whisperer)" |
Prompt To Fix With AI
This is a comment left during a code review.
Path: unstract/sdk1/src/unstract/sdk1/adapters/x2text/llm_whisperer_v2/src/static/json_schema.json
Line: 27
Comment:
Same pattern as in v1: the `title` now reads "LLMWhisperer Key" but the `description` still directs users to the "Unstract developer portal". The two fields are shown together in the adapter config form, so aligning the portal name keeps the messaging consistent.
```suggestion
"description": "API key obtained from the [LLMWhisperer portal](https://us-central.unstract.com/landing?selectedProduct=llm-whisperer)"
```
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Unstract test resultsPer-group results
Critical paths
|
2 participants
What
unstract_keyfield's display label from Unstract Key to LLMWhisperer Key in both LLMWhisperer (v1) and LLMWhisperer v2 X2Text adapter JSON schemas.Why
How
titleof theunstract_keyproperty inunstract/sdk1/.../x2text/llm_whisperer/src/static/json_schema.jsonand.../llm_whisperer_v2/src/static/json_schema.json.Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
titleis display-only in the JSON schema; the property keyunstract_key(which backend code and the cloud subscription-plugin schema transform reference) is unchanged.Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
grep -rn '"Unstract Key"'now returns no occurrences in the repo; only the two schema titles changed.Screenshots
Checklist
I have read and understood the Contribution Guidelines.
🤖 Generated with Claude Code