Repository navigation
ZEUS: pub_inmemory_signer_new feature makes InMemorySigner::new public - #3
Merged
Merged
Conversation
InMemorySigner::new is public only with _test_utils, which also compiles LDK's test utilities and the C++ bitcoinconsensus into the build. The zeus-vls self-recovery kit (lightningdevkit#269) builds InMemorySigners from vlsd's channel keys, which it derives from the customer's seed, and ships as a static release binary. This feature makes the constructor public with nothing else. Off by default; no behaviour change when unused.
kaloudis
force-pushed
the
zeus-0.2.7-pub-signer-new
branch
from
October 8, 2026 03:20
89b6184 to
e65c0be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
pub_inmemory_signer_newfeature tolightningthat makesInMemorySigner::newpublic, which upstream allows only under_test_utils.Why: the zeus-vls self-recovery kit (ZeusLN/zeus-vls#269) builds
InMemorySigners from vlsd's channel keys, which it derives from the customer's seed. It ships as a static release binary. Getting the constructor through_test_utilsalso compiles LDK's test utilities and the C++bitcoinconsensusinto the release (no musl C++ compiler in the pinned build image), and_test_utilsturns off the stalechannel_updatecheck in gossip (routing/gossip.rs).Change: one feature declaration and the
cfgon the twonewvariants. Off by default; with the feature off the code is unchanged.Checked:
cargo check -p lightningwith and without the feature. lnrod pins this rev (89b6184b) in the kit packaging PR; merging this intozeus-0.2.7as a fast-forward keeps the rev.