Repository navigation
ZEUS: fix CI on zeus-0.2.7 - #4
Merged
Merged
Conversation
cargo fmt --check failed on zeus-0.2.7: the LSPS7 client patch was not formatted, and v0.2.7 itself carries three unformatted backport hunks (channelmonitor.rs, chanmon_update_fail_tests.rs, functional_tests.rs). Whitespace and import order only.
macro_logger.rs's log-truncation tests (from a v0.2.x backport) build long strings with iter::repeat().take().collect(), which clippy 1.93+ rejects. Allowed with the other test-only lints instead of changing upstream code.
quinn 0.11.12 requires quinn-proto 0.11.18, so the existing quinn-proto 0.11.15 pin no longer resolved; pin quinn 0.11.11 first. hyper-util 0.1.21 is edition 2024, which cargo 1.75 cannot parse; pin 0.1.20.
Upstream runs ext-test, the Linux build matrix, coverage, check_docs, fuzz and check_commits on its self-hosted runners and semver-checks on a debian-trixie runner. This repository has neither, so those jobs waited 24 hours and failed. They run on ubuntu-latest; the fuzz job installs binutils-dev and libunwind-dev, which honggfuzz needs to build there. Every stable and beta job uses rustc 1.96.1, the rustc zeus-vls builds with (bump both together), next to the MSRV jobs. The floating toolchains broke a fixed v0.2.x tree for reasons unrelated to the code: new clippy lints, beta rustdoc no longer resolving a std intra-doc link in lightning-block-sync, and rustc 1.100 failing to build the crates.io lightning 0.0.125 that lightning-tests uses for upgrade tests. Removed: coverage, which only uploaded to upstream's Codecov project with upstream's token, and semver-checks, which compares against crates.io's lightning 0.2.7 and cannot pass because the fork changes public API on purpose (Bolt11InvoiceParameters.route_hints_override); the fork is consumed by git rev. check_commits rebased onto upstream/<base>, which does not exist for fork branches; it now checks each commit against origin/<base>.
kaloudis
force-pushed
the
zeus-0.2.7-ci
branch
from
October 8, 2026 03:19
25d66cc to
1c3b7e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on
zeus-0.2.7has failed on every run, including this PR's base4371384dand #3. The causes are the fork's CI setup and dependency drift; none come from the ZEUS patches' logic.Changes
9e25a29b):cargo fmtwith 1.63.0 (the CI toolchain). The LSPS7 client patch was unformatted, and v0.2.7 itself carries three unformatted backport hunks. Whitespace and import order only.5bddbc2d,1c3b7e95): clippy ran onstable, and each release adds lints the v0.2.x code fails (1.98.1 and 1.99 fail on different ones). Everystable/betajob now uses 1.96.1, the zeus-vls rustc (beta also broke check_docs and, on rustc 1.100, the crates.io lightning 0.0.125 thatlightning-testsbuilds). One test-only lint,clippy::manual_str_repeat(macro_logger.rstests from a backport), is added tocheck-lint.sh's test allow list instead of changing upstream code.66281840):quinn0.11.12 needsquinn-proto0.11.18, so the existingquinn-protopin no longer resolved;quinnis pinned to 0.11.11 first.hyper-util0.1.21 is edition 2024, so it is pinned to 0.1.20.1c3b7e95): upstream'sself-hostedanddebian-trixiejobs never started here and failed after 24 hours. They now run onubuntu-latest. The fuzz job installsbinutils-devandlibunwind-devfor honggfuzz. The coverage job is removed because it only uploaded to upstream's Codecov project with upstream's token. semver-checks is removed: it compares against crates.io's lightning 0.2.7, and the fork changes public API on purpose (Bolt11InvoiceParameters.route_hints_override).check_commitsrebased ontoupstream/<base>, which does not exist for fork branches; it now checks each commit againstorigin/<base>.Local checks
cargo +1.63.0 fmt --checkis clean, in the root and inlightning-tests.ci/check-lint.shon 1.96.1 exits 0.ci/ci-tx-sync-tests.shon 1.75.0 with-D warningspasses thecargo checksteps for all four features. The tests need bitcoind and electrs, which CI provides.All 33 checks passed on the pre-squash head
25d66cce, which has the same tree as1c3b7e95(the last two commits were squashed). Build jobs take 1.5 to 2.8 hours on hosted runners; fuzz about 42 minutes.