SequentialPlacer takes into account max channels per tile by AndraBisca · Pull Request #2221 · Xilinx/mlir-aie

AndraBisca · 2025-04-24T12:58:26Z

TODO:

get tile max channel information from target model
differentiate between input and output channels
add tests
cleanup and comment code
add better error messaging
also account for channels used in Worker placement
use shim_mux connections to determine channels for shim tiles

Partly addresses issues in #1757

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…to update-placer

…els.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…to update-placer

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…to update-placer

jgmelber · 2025-04-28T22:30:35Z

mlir-aie/programming_examples/basic/memcpy/memcpy.py

Line 93 in 065aae2

placement=Tile(i, 0), # Explicitly placed until #2221

mlir-aie/programming_examples/basic/memcpy/memcpy.py

Line 101 in 065aae2

placement=Tile(i, 0), # Explicitly placed until #2221

jgmelber · 2025-04-28T22:53:29Z

mlir-aie/programming_examples/basic/memcpy/memcpy.py

Line 41 in 3422189

.forward(placement=Tile(i, 1)) # Explicitly placed until #2221)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…to update-placer

jgmelber · 2025-05-07T12:31:26Z

RTM?

fifield · 2025-05-07T14:25:36Z

RTM?

yes, please merge placers.py into AIEPlacers.cpp :)

Co-authored-by: AndraBisca <andrab@amd.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Joseph Melber <jmelber@xilinx.com>

abisca and others added 22 commits April 24, 2025 06:50

Placer now takes into account max channels per tile

ff919d9

Restore example modified by mistake

4a68cfa

Update python/iron/placers.py

655b843

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update python/iron/placers.py

a731c22

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Get max channels per tile from target model

d5d1d2a

Merge branch 'update-placer' of https://github.com/Xilinx/mlir-aie in…

ef87766

…to update-placer

Enable functions to retrieve number of DMA connections

219c27b

Add test. Ensure there is a difference between input and output chann…

3ec0f8d

…els.

Update include/aie-c/TargetModel.h

f56af92

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update include/aie-c/TargetModel.h

6dd3857

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update lib/CAPI/TargetModel.cpp

344be2a

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Use proper test function

a769306

Merge branch 'update-placer' of https://github.com/Xilinx/mlir-aie in…

4f81476

…to update-placer

Error message. Python format.

c472821

Python format

4153c43

Update test

2c5b71d

Update lib/CAPI/TargetModel.cpp

daa09a3

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update python/AIEMLIRModule.cpp

2129124

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update python/AIEMLIRModule.cpp

67bae0d

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Python format

a71c875

Merge branch 'update-placer' of https://github.com/Xilinx/mlir-aie in…

0d5ecce

…to update-placer

Update tests

878d28f

jgmelber mentioned this pull request Apr 28, 2025

All example kernels execution result in ERT_CMD_STATE_ERROR on the Windows host #1757

Closed

AndraBisca and others added 5 commits April 29, 2025 09:06

Update test/python/dma_channels_per_tile.py

0c27140

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update test/python/dma_channels_per_tile.py

963a9bb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update test/python/dma_channels_per_tile.py

c2e1807

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update test/python/dma_channels_per_tile.py

cb287f3

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Sequential placer now iterates only once over each endpoint.

8ce60c1

jgmelber reviewed May 5, 2025

View reviewed changes

Comment thread python/iron/placers.py Outdated

jgmelber reviewed May 5, 2025

View reviewed changes

Comment thread python/AIEMLIRModule.cpp Outdated

abisca and others added 9 commits May 5, 2025 09:43

Use shim mux connections for shim tiles

2dc02e6

Update lib/CAPI/TargetModel.cpp

d344cfd

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update lib/CAPI/TargetModel.cpp

b381501

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update python/AIEMLIRModule.cpp

33f3df8

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update python/AIEMLIRModule.cpp

787fe3e

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update python/AIEMLIRModule.cpp

479d967

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update python/AIEMLIRModule.cpp

ca9097f

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Try to fix dict error

b49f323

Merge branch 'update-placer' of https://github.com/Xilinx/mlir-aie in…

719c01b

…to update-placer

AndraBisca marked this pull request as ready for review May 6, 2025 11:56

abisca and others added 4 commits May 6, 2025 09:22

Add test for custom placement

fc38754

Use dict like a dict

9986f7c

Fix dict initialization

22d2b43

Use empty dict not list

b478a1f

jgmelber approved these changes May 6, 2025

View reviewed changes

abisca and others added 5 commits May 7, 2025 01:26

Merge branch 'update-placer' of https://github.com/Xilinx/mlir-aie in…

ed941ce

…to update-placer

Use dict with default empty list. Add doc.

8b25add

Merge branch 'main' into update-placer

94eec9f

Remove defaultdict

7cc5b4f

Merge branch 'update-placer' of https://github.com/Xilinx/mlir-aie in…

d812339

…to update-placer

jgmelber approved these changes May 7, 2025

View reviewed changes

AndraBisca added this pull request to the merge queue May 7, 2025

Merged via the queue into main with commit 90a5fcf May 7, 2025
51 checks passed

AndraBisca deleted the update-placer branch May 7, 2025 14:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SequentialPlacer takes into account max channels per tile#2221

SequentialPlacer takes into account max channels per tile#2221
AndraBisca merged 56 commits intomainfrom
update-placer

AndraBisca commented Apr 24, 2025 •

edited

Loading

Uh oh!

jgmelber commented Apr 28, 2025

Uh oh!

jgmelber commented Apr 28, 2025

Uh oh!

Uh oh!

Uh oh!

jgmelber commented May 7, 2025

Uh oh!

fifield commented May 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

AndraBisca commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jgmelber commented Apr 28, 2025

Uh oh!

jgmelber commented Apr 28, 2025

Uh oh!

Uh oh!

Uh oh!

jgmelber commented May 7, 2025

Uh oh!

fifield commented May 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AndraBisca commented Apr 24, 2025 •

edited

Loading