fix: Handle rounding just above kMaxRep more accurately#7389
Open
ximinez wants to merge 131 commits into
Open
Codecov / codecov/project
succeeded
Jun 18, 2026 in 1s
82.0% (target 75.0%)
View this Pull Request on Codecov
82.0% (target 75.0%)
Details
Codecov Report
❌ Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.0%. Comparing base (14a43cf) to head (39d8507).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/libxrpl/basics/Number.cpp | 95.2% | 2 Missing |
Additional details and impacted files
@@ Coverage Diff @@
## ximinez/number-round-maxrep-down #7389 +/- ##
================================================================
Coverage 82.0% 82.0%
================================================================
Files 1007 1007
Lines 76882 76912 +30
Branches 8983 8995 +12
================================================================
+ Hits 63012 63041 +29
- Misses 13861 13862 +1
Partials 9 9 | Files with missing lines | Coverage Δ | |
|---|---|---|
| include/xrpl/basics/Number.h | 100.0% <ø> (ø) |
|
| src/libxrpl/basics/Number.cpp | 98.3% <95.2%> (-0.3%) |
⬇️ |
... and 1 file with indirect coverage changes
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Loading