fix: Handle rounding just above kMaxRep more accurately#7389
Open
ximinez wants to merge 131 commits into
Open
Codecov / codecov/project
succeeded
Jun 19, 2026 in 1s
82.0% (target 75.0%)
View this Pull Request on Codecov
82.0% (target 75.0%)
Details
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.0%. Comparing base (d373cb5) to head (aadf3c6).
Additional details and impacted files
@@ Coverage Diff @@
## ximinez/number-round-maxrep-down #7389 +/- ##
================================================================
Coverage 82.0% 82.0%
================================================================
Files 1007 1007
Lines 76882 76914 +32
Branches 8983 8994 +11
================================================================
+ Hits 63005 63041 +36
+ Misses 13868 13864 -4
Partials 9 9 | Files with missing lines | Coverage Δ | |
|---|---|---|
| include/xrpl/basics/Number.h | 100.0% <ø> (ø) |
|
| src/libxrpl/basics/Number.cpp | 98.6% <100.0%> (+0.1%) |
⬆️ |
... and 4 files with indirect coverage changes
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Loading