fix: Handle rounding just above kMaxRep more accurately#7389
Open
ximinez wants to merge 131 commits into
Open
Codecov / codecov/project
succeeded
Jun 15, 2026 in 1s
82.0% (target 75.0%)
View this Pull Request on Codecov
82.0% (target 75.0%)
Details
Codecov Report
❌ Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.0%. Comparing base (b435594) to head (2f59cb0).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/libxrpl/basics/Number.cpp | 95.2% | 2 Missing |
Additional details and impacted files
@@ Coverage Diff @@
## ximinez/number-round-maxrep-down #7389 +/- ##
==================================================================
- Coverage 82.3% 82.0% -0.3%
==================================================================
Files 1009 1009
Lines 76956 76858 -98
Branches 8931 8947 +16
==================================================================
- Hits 63354 63049 -305
- Misses 13593 13800 +207
Partials 9 9 | Files with missing lines | Coverage Δ | |
|---|---|---|
| include/xrpl/basics/Number.h | 99.4% <ø> (ø) |
|
| src/libxrpl/basics/Number.cpp | 98.4% <95.2%> (+0.1%) |
⬆️ |
... and 74 files with indirect coverage changes
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Loading