Repository navigation
紹介画像をフォントと図形で作成した画像へ差し替え - #37
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変更内容
共有時に使われる生成画像を、実際のフォントと図形で構成した画像へ差し替えます。文言と1200×630のサイズを維持し、編集可能なSVGも追加しました。PNGはSharpで書き出しています。
公開前のCIで、既存の画面遷移テスト3件が
URL is not definedで失敗することを確認しました。直近の画面遷移修正に合わせ、テストのVMへブラウザのURLコンストラクターとページURLを渡し、期待値を絶対URLに更新しました。アプリ本体の動作は変更していません。検証