Repository navigation
Add isolated interactive Canvas previews - #164
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Preserve browser credential guards, register both schemes together, and keep Canvas usable with pane-local Streamer coverage and original filename values. Ignore manual reload results after their selection loses ownership. Coven-Harness: Codex / gpt-6-astra
Keep full endpoint coverage required while allowing the polling assertion to wait for highlights belonging to the current quote tree. Coven-Harness: Codex / gpt-6-astra
Allow one bounded retry while the original menu action remains ready and require the actual welcome screen before continuing the demo lifecycle. Coven-Harness: Codex / gpt-6-astra
Reuse bounded action completion for demo Back transitions and require the actual dashboard. Exercise an ignored first tap in a native regression. Coven-Harness: Codex / gpt-6-astra
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workspace now previews local HTML, SVG, and Markdown in a Canvas tab. Local scripts remain interactive; document and asset edits refresh the preview, full view expands it, and unavailable files recover when restored.
Each preview uses a temporary isolated Electron session, no Node/preload/app bridge, root-confined and bounded resource reads, and blocked remote requests and privileged navigation. The Store client and browser development bridge report Canvas unavailable. Integration with merged #152 preserves browser credential/frame guards and registers attachment/Canvas schemes together. Streamer Mode covers only the preview and masks filename labels while retaining raw paths and document state; stale reload responses cannot restore a cleared selection.
Verification:
27efcc8: both jobs passed 234 desktop and seven site cases; units passed 702 with one opt-in skip. Its PR iPhone job passed all 27 UI cases.b3f8497: full build and 703 local unit tests passed with zero skips; all 470 tracked hashes stayed unchanged during that gate. Full exact-head hosted checks are pending.Earlier hosted failures and repairs are retained in
docs/reviews/2026-10-11-desktop-roadmap-audit.md: detached DOM ranges in a Streamer assertion, an undismissed demo menu after a tap, and an ineffective Back transition before the exit step. Test observations now check current ownership/state, require the actual destination, and allow at most one action retry while its original control remains ready. Existing masking, isolation, exit, deep-link and relaunch assertions remain. The exact cause of the hosted tap failures is not claimed proven; application code was unchanged by these follow-ups.This is the Canvas stage of the desktop roadmap. Packaged release acceptance, authenticated automatic updates, and final native Windows/Linux delivery remain separate. Usage and limits are in
docs/canvas.md. Retain this branch for stacked #173; no release is claimed here.