Repository navigation
Conversation
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Freeze question IDs, favorable directions, and proposal-tool metadata at runtime and expose readonly types. Reviewed both mutation resistance and the regression demonstrating that attempts to empty the question list cannot bypass evaluation. Synchronized prerequisite fixes; no additional policy change was needed.
Ported from romgenie-following-repos#4.
Verdict impact
None from this step. Frozen metadata prevents mutation of the existing decision policy.
Review and verification
No additional defect found in the immutable metadata change. Reviewed the incremental code, tests, API boundaries, and documentation. No remaining actionable finding was identified within this PR's scope.
pnpm typecheckandpnpm testpassed locally on the current branch.pnpm check:secrets, pre-commit checks, and gitleaks over the complete final-stack history passed.Local toolchain: Node 24.18.0, pnpm 10.34.5. Reviewed head: ec7bdba15327726560c5209ed1d24149e1662045. Hosted CI requires upstream maintainer approval for fork workflows; local validation is not a hosted CI pass. Ready for human review, not merged.
Stack
Depends on #11. Review this concern using the incremental diff. Next: #13.
These cross-fork PRs target upstream main because the publishing account cannot create upstream base branches. Later PRs therefore include prerequisite changes. Merge in order using the required squash policy, then rebase/retarget the remaining PRs as needed. This review update preserves published history through signed merges; no force-push was used.