Skip to content

fix: fail closed on malformed runtime validation and review inputs - #11

Merged
BunsDev merged 9 commits into
TypeSafeAI:mainfrom
romgenie-following-repos:sideload/review-03-runtime-inputs
Sep 22, 2026
Merged

BunsDev merged 9 commits into
TypeSafeAI:mainfrom
romgenie-following-repos:sideload/review-03-runtime-inputs

Conversation

@CompleteDotTech

@CompleteDotTech CompleteDotTech commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

What changed

Validate runtime decision inputs as plain data. Malformed validation rejects; a missing or malformed review envelope is unavailable; unusable individual answers degrade to proposal-only. Dense error arrays are copied from own data properties so custom iterators cannot hide failures and index getters are not invoked.

Ported from romgenie-following-repos#3.

Verdict impact

Malformed or contradictory validation produces reject, including arrays whose custom iterator previously hid errors. Malformed review envelopes produce unavailable; partial answer objects produce proposal_only. Canonical fixture verdicts are unchanged.

Review and verification

Reproduced and fixed an iterator-based validation bypass; added getter/iterator regression coverage. Reviewed the incremental code, tests, API boundaries, and documentation. No remaining actionable finding was identified within this PR's scope.

  • Pinned frozen pnpm install; dependencies and lockfile preserved.
  • pnpm typecheck and pnpm test passed locally on the current branch.
  • pnpm check:secrets, pre-commit checks, and gitleaks over the complete final-stack history passed.
  • New commits are signed and locally verified; GitHub verifies this head.
  • No live provider call, credential, execution path, model-pin change, or new verdict added.

Local toolchain: Node 24.18.0, pnpm 10.34.5. Reviewed head: 0b1df9e64858212c16455f0911d338cda56d9032. Hosted CI requires upstream maintainer approval for fork workflows; local validation is not a hosted CI pass. Ready for human review, not merged.

Stack

Depends on #10. Review this concern using the incremental diff. Next: #12.

These cross-fork PRs target upstream main because the publishing account cannot create upstream base branches. Later PRs therefore include prerequisite changes. Merge in order using the required squash policy, then rebase/retarget the remaining PRs as needed. This review update preserves published history through signed merges; no force-push was used.

@CompleteDotTech
CompleteDotTech marked this pull request as ready for review September 22, 2026 10:26
@BunsDev
BunsDev merged commit 105b973 into TypeSafeAI:main Sep 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants