Add clippy to Travis and remove unnecessary code

.travis.yml

@@ -20,7 +20,16 @@ matrix:
       before_script:
         - rustup component add rustfmt-preview
       script:
-        - cargo fmt --all -- --write-mode=diff
+        - cargo fmt --all -- --check
+    - env:
+        - NAME='clippy'
+        # use env so updating versions causes cache invalidation
+        - CLIPPY_VERSION=0.0.212
+      rust: nightly-2018-07-22
+      before_script:
+        - cargo install clippy --version $CLIPPY_VERSION || echo "clippy already installed"
+      script:
+        - cargo clippy --all --tests --all-features -- -D clippy
     - env: NAME='kcov'
       sudo: required # travis-ci/travis-ci#9061
       before_script:
@@ -30,7 +39,7 @@ matrix:
       script:
         - cargo kcov --print-install-kcov-sh | sh
         - cargo update # Creates `Cargo.lock` needed by next command
-        - cargo kcov --verbose --features dss --coveralls -- --verify --exclude-pattern=/.cargo,/usr/lib,src/proto
+        - cargo kcov --verbose --coveralls -- --verify --exclude-pattern=/.cargo,/usr/lib,src/proto
       addons:
         apt:
           packages:
@@ -47,4 +56,4 @@ env:
 script:
   - cargo build --verbose --all-features
   - cargo test --verbose --all-features
-  - cargo doc --verbose --all-features
+  - cargo doc --verbose --all-features --no-deps

Cargo.toml

@@ -20,10 +20,6 @@ exclude = ["Cargo.lock"]
 travis-ci = { repository = "SpinResearch/RustySecrets", branch = "master" }
 coveralls = { repository = "SpinResearch/RustySecrets", branch = "master", service = "github" }
 
-[features]
-default = []
-dss = []
-
 [dependencies]
 base64 = "0.9.0"
 rand = "^0.4.2"

fuzz/Cargo.toml

@@ -20,14 +20,6 @@ git = "https://github.com/rust-fuzz/libfuzzer-sys.git"
 [workspace]
 members = ["."]
 
-[[bin]]
-name = "ss1_1"
-path = "fuzz_targets/ss1_1.rs"
-
-[[bin]]
-name = "thss_1"
-path = "fuzz_targets/thss_1.rs"
-
 [[bin]]
 name = "sss_1"
 path = "fuzz_targets/sss_1.rs"

protobuf/Makefile

@@ -7,24 +7,19 @@ DEST_DIR := ../src/proto
 BASE_PROTOS := $(wildcard *.proto)
 BASE_RUSTS := $(addprefix $(DEST_DIR)/, $(BASE_PROTOS:.proto=.rs))
 
-DSS_PROTOS := $(wildcard dss/*.proto)
-DSS_RUSTS := $(addprefix $(DEST_DIR)/, $(DSS_PROTOS:.proto=.rs))
-
 WRAPPED_PROTOS := $(wildcard wrapped/*.proto)
 WRAPPED_RUSTS := $(addprefix $(DEST_DIR)/, $(WRAPPED_PROTOS:.proto=.rs))
 
 OUT_DIR := _out
 
-.PHONY: all base wrapped dss clean
+.PHONY: all base wrapped clean
 
-all: base wrapped dss
+all: base wrapped
 
 base: $(BASE_RUSTS)
 
 wrapped: $(WRAPPED_RUSTS)
 
-dss: $(DSS_RUSTS)
-
 $(DEST_DIR)/%.rs: %.proto
 	@echo -n "Processing '$<'..."
 	@$(RM) -r $(OUT_DIR)
@@ -39,4 +34,3 @@ $(DEST_DIR)/%.rs: %.proto
 clean:
 	$(RM) $(BASE_RUSTS)
 	$(RM) $(WRAPPED_RUSTS)
-	$(RM) $(DSS_RUSTS)