Add clippy to Travis and remove unnecessary code

[romac]

On hold. See #66 (comment).

[psivesely]

- cargo clippy --all --tests --all-features -- -D clippy

[psivesely]

Maybe wait on this until a unified Travis testing strategy is figured out for all the RustySecrets related repositories (see SpinResearch/merkle.rs#36 (comment)).

[romac]

@nvesely Agreed.

[psivesely]

I'm working on a solution I'm testing in github.com/nvesely/winternitz. The idea is that a Rust nightly version is pinned as well as a clippy version. As @afck pointed out rustup component add rustfmt-preview will effectively pin a rustfmt version (see SpinResearch/merkle.rs#36 (comment)).

Additionally, commands are added to the Makefile so that one neither needs to remember/ type the correct version of Rust nightly or all the options one must pass to clippy or rustfmt. Commands are added both to install what's necessary to format and lint and to run these tools with the set of options to match Travis/ our expectations.

One shouldn't need to update the pinned versions more than every couple of months or so and it should be possible to store the values only in the Makefile (and have Travis read them from there).

I think this solves a few problems:

• Travis builds should never suddenly break on master because, e.g., rustfmt updated.
• PR diffs will be cleaner because no code that is not new will be present.
• The inconveniences and potential problems mentioned in Add MerkleTree::gen_nth_proof and Proof::index. merkle.rs#36 (comment) are alleviated.

[afck]

Clippy can now also be installed via rustup (instead of cargo install), so you don't have to manually match Clippy versions to the corresponding Rust nightlies anymore. And it will even be part of one of the upcoming stable versions! 🎉
https://internals.rust-lang.org/t/clippy-is-available-as-a-rustup-component/7967

[psivesely]

That simplifies things a lot. Ideally our CI is simply not as complicated as some of the ideas we were discussing a month or two back 😺