feat(nav): surface Datasets in primary navigation - #754
Merged
Conversation
Add the localized Datasets destination to the desktop and mobile header, preserve child-route active state, and cover responsive plus route-level navigation behavior. 中文：在桌面端和移动端顶层导航中加入本地化的“数据集”入口，保留子路由高亮状态，并补充响应式布局与实际路由跳转测试。
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cquil11
marked this pull request as ready for review
August 18, 2026 20:38
functionstackx
added a commit
that referenced
this pull request
Aug 18, 2026
The sixth primary nav link (Datasets, #754) pushed the header's right-hand controls 3.5px past a 1024px viewport: brand (199px) + nav (523px) + controls (210px) + two 24px gaps = 980px in a 945px container. The page then scrolled sideways, which fails the overview suite's `expectNoHorizontalOverflow()` at width 1024 — the shard-3 E2E failure already present on master, reproduced locally with this branch's label change reverted. Tighten the row gap and the nav-link padding between `lg` and `xl` (gap-6 → gap-3, px-3 → px-2), which frees 72px where the nav is tightest and leaves the `xl` layout byte-identical. Adds a header-fit regression test at 1024 / 1100 / 1279 px; it fails without this change. 中文：第六个主导航链接（Datasets，#754）使页头右侧控件在 1024px 视口下超出 3.5px：品牌区 199px + 导航 523px + 控件 210px + 两个 24px 间距 = 980px，而容器 仅 945px，导致页面出现横向滚动，触发 overview 套件在 1024 宽度下的 `expectNoHorizontalOverflow()` 断言失败——这正是 master 上已存在的 shard-3 E2E 失败（本地回退本分支的标签改动后可复现）。 修复方式：在 `lg` 与 `xl` 之间收紧行间距与导航链接内边距（gap-6 → gap-3、 px-3 → px-2），在导航最紧张的区间释放 72px，同时保持 `xl` 及以上布局完全不变。 新增 1024 / 1100 / 1279 px 的页头布局回归测试；未修复时该测试会失败。 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/zh/datasetsheader_datasets_clickedUser impact
Agentic trace datasets and their methodology are now directly discoverable from every page instead of requiring a footer link or direct URL.
Validation
bun run buildwithE2E_FIXTURES=1bun run typecheckbun run lintbun run fmtvitest run src/lib/tab-meta-zh.test.ts(28 assertions)header.cy.tsx(23 tests)navigation.cy.ts,zh-pages.cy.ts(24 tests)Merge order
Independent; no dependency on another PR.
Note
Low Risk
Navigation and localization changes only; no auth, data, or core inference logic touched.
Overview
Datasets moves from footer-only discovery into the primary header on desktop and mobile, with clicks tracked via
header_datasets_clicked.On
/zhroutes the nav shows 数据集, links to/zh/datasets, and stays active on dataset detail paths (e.g./datasets/claude-code-traces) through the existing child-path active logic. Cypress coverage was updated so Datasets is expected in primary nav and footer-only assertions were removed.Reviewed by Cursor Bugbot for commit e80554d. Bugbot is set up for automated code reviews on this repo. Configure here.