fix(labels): render Kimi K3 speculative decoding as "DSpark" / 将 Kimi K3 的投机解码显示为 "DSpark" - #759
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This comment has been minimized.
This comment has been minimized.
Kimi K3 speculative-decoding runs are ingested under the generic `mtp` token, but K3's method is DSpark, so every surface read "MTP". Add a per-model override in MODEL_SPEC_METHOD_LABELS (same mechanism already used for MiniMax-M3 → "M3 EAGLE"), which fixes the label everywhere it is derived: the chart tooltip's "Speculative Decoding" line, hardware suffixes such as "B300 (vLLM, MTP)", the submissions table, evaluation headers, changelog entries, the overview matrix, and the spec-decode comparison pages. Other models keep the generic "MTP" label. 中文:Kimi K3 的投机解码运行在数据入库时使用通用的 `mtp` 标记,但 K3 实际 使用的方法是 DSpark,因此各处显示都是 "MTP"。在 MODEL_SPEC_METHOD_LABELS 中新增按模型的显示覆盖(与 MiniMax-M3 → "M3 EAGLE" 复用同一机制),一次性 修正所有由该映射派生的展示位置:图表工具提示中的"投机解码"行、"B300 (vLLM, MTP)" 之类的硬件后缀、提交记录表格、评估表头、变更日志、总览矩阵以及投机解码 对比页面。其他模型仍保留通用的 "MTP" 标签。 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
functionstackx
force-pushed
the
fix/kimi-k3-dspark-spec-label
branch
from
August 18, 2026 23:02
db62466 to
a78da27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Kimi K3's speculative-decoding runs are ingested under the generic
mtptoken, so every display surface read MTP — including the chart tooltip line in the reported screenshot. K3's method is DSpark.This adds a per-model display override in
MODEL_SPEC_METHOD_LABELS(packages/constants/src/framework-aliases.ts), the same mechanism already used for MiniMax-M3 (mtp→M3 EAGLE):Every label surface resolves through
resolveFrameworkPartLabel/specMethodDisplayLabel, so the one-line override fixes all of them at once:Speculative Decoding: DSpark(both the official and the?unofficialrun=overlay path — they sharegenerateAgenticHTML)B300 (vLLM, DSpark)instead ofB300 (vLLM, MTP)(getHardwareConfig)/compare-spec-decode/*and/zh/compare-spec-decode/*)Every other model keeps the generic
MTPlabel;nonestill renders asOff/关闭.No
/zhpage changes are needed —DSparkis a method/product name, which per the translation quality bar stays in English on both language sides (the surrounding label投机解码was already translated).Note on the earlier E2E failure
The first run of this PR failed
E2E (chrome|firefox, shard 3)onoverview.cy.ts(expected 1012 to be at most 1009). That was pre-existing master breakage, not this change: the same shards failed on #754 before it merged, and the failure reproduced locally with this branch's label change reverted. The cause was the header's desktop nav overflowing a 1024px viewport. #755 has since moved the desktop nav to thexlbreakpoint, which resolves it at the root, so after rebasing onto master this branch carries only the label change —overview.cy.tspasses locally on the rebased tree (35/35).Tests
packages/constants/src/framework-aliases.test.ts—MODEL_SPEC_METHOD_LABELS['Kimi-K3'].mtp === 'DSpark',resolveFrameworkPartLabel('Kimi-K3', 'mtp') === 'DSpark', plus a guard that sibling Kimi models (Kimi-K2.5) keepMTPpackages/app/src/components/inference/utils/tooltip-utils.test.ts— K3 agentic tooltip rendersSpeculative Decoding: DSparkand no longer contains the genericMTP(exercises the overlay tooltip path)Local on the rebased tree:
typecheck,lint,fmt,test:unit(app 3427, constants 44), plusoverview.cy.tsandnavigation.cy.tsin Chrome against a production build withE2E_FIXTURES=1— all green.中文说明
Kimi K3 的运行数据在入库时统一使用通用的
mtp标记,因此所有展示位置都显示为 MTP(包括截图中的图表工具提示)。K3 实际使用的方法是 DSpark。改动在
MODEL_SPEC_METHOD_LABELS(packages/constants/src/framework-aliases.ts)中新增按模型的显示覆盖,复用 MiniMax-M3(mtp→M3 EAGLE)已有的同一机制。由于所有标签都经由resolveFrameworkPartLabel/specMethodDisplayLabel解析,这一行改动可一次性修正全部展示位置:Speculative Decoding: DSpark(官方数据与?unofficialrun=叠加两条路径共用generateAgenticHTML,均已覆盖)B300 (vLLM, DSpark)/compare-spec-decode/*与/zh/compare-spec-decode/*)其他模型仍保留通用的
MTP标签,none依然显示为Off/关闭。无需改动/zh页面:按翻译规范,DSpark属于方法名称,中英两侧均保留英文。关于此前的 E2E 失败
本 PR 首次运行时
E2E (chrome|firefox, shard 3)在overview.cy.ts上失败(expected 1012 to be at most 1009),这是 master 上已存在的问题,与本次改动无关:#754 合并前同样的分片就已失败,且在本分支回退标签改动后仍可本地复现。根因是页头桌面导航在 1024px 视口下溢出;#755 已将桌面导航移至xl断点,从根本上解决了该问题。因此在基于 master 变基后,本分支只保留标签改动,overview.cy.ts在变基后的本地环境中 35/35 通过。测试
新增常量层映射与解析用例(含
Kimi-K2.5仍为MTP的回归保护),以及工具提示渲染DSpark的单元测试。变基后本地typecheck、lint、fmt、test:unit(app 3427、constants 44)与相关 Cypress 规格全部通过。🤖 Generated with Claude Code